Skip to content

Commit e65fcab

Browse files
committed
update proptypes
1 parent 0cd9daa commit e65fcab

File tree

5 files changed

+27
-14
lines changed

5 files changed

+27
-14
lines changed

src/components/lesson/Lesson.js

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,16 @@ const Lesson = ({ lesson, course_size, base_path }) => (
1313
);
1414

1515
Lesson.propTypes = {
16-
title: PropTypes.string.isRequired,
17-
src: PropTypes.string.isRequired,
18-
description: PropTypes.string.isRequired,
19-
order: PropTypes.number.isRequired,
16+
lesson: PropTypes.shape({
17+
title: PropTypes.string.isRequired,
18+
src: PropTypes.string.isRequired,
19+
description: PropTypes.string.isRequired,
20+
order: PropTypes.number.isRequired,
21+
yt_chan_name: PropTypes.string.isRequired,
22+
yt_chan_src: PropTypes.string.isRequired,
23+
yt_title: PropTypes.string.isRequired,
24+
yt_desc: PropTypes.string.isRequired,
25+
}).isRequired,
2026
course_size: PropTypes.number.isRequired,
2127
base_path: PropTypes.string.isRequired,
2228
};

src/components/lesson/LessonInfo.js

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,29 +16,37 @@ const LessonInfo = ({ lesson, base_path, course_size }) => {
1616
<hr />
1717
<p id="lesson-description">{description || 'No description provided'}</p>
1818
<hr />
19+
1920
<div id="yt-info">
20-
{/* link to YT chan, original video name, desc */}
2121
<h3 className="subheader">Youtube credits</h3>
2222
<p id="yt-chan">
2323
<span className="title">Creator: </span>
24-
<a href={yt_chan_src} target="_blank" rel="noopener noreferrer">{yt_chan_name || 'YouTube Channel'}</a>
24+
<a href={yt_chan_src} target="_blank" rel="noopener noreferrer">{yt_chan_name || 'YouTube Channel goes here'}</a>
2525
</p>
2626
<p id="yt-title">
2727
<span className="title">Video title: </span>
2828
<a href={getVideoURL(src)} target="_blank" rel="noopener noreferrer">{yt_title || 'Original YouTube Video'}</a>
2929
</p>
3030
<p id="yt-desc">
3131
<span className="title">Video Description: </span>
32-
{yt_desc || 'YouTube description'}
32+
{yt_desc || 'YouTube description goes here'}
3333
</p>
3434
</div>
3535
</div>
3636
);
3737
};
38+
3839
LessonInfo.propTypes = {
39-
title: PropTypes.string.isRequired,
40-
description: PropTypes.string.isRequired,
41-
order: PropTypes.number.isRequired,
40+
lesson: PropTypes.shape({
41+
title: PropTypes.string.isRequired,
42+
src: PropTypes.string.isRequired,
43+
description: PropTypes.string.isRequired,
44+
order: PropTypes.number.isRequired,
45+
yt_chan_name: PropTypes.string.isRequired,
46+
yt_chan_src: PropTypes.string.isRequired,
47+
yt_title: PropTypes.string.isRequired,
48+
yt_desc: PropTypes.string.isRequired,
49+
}).isRequired,
4250
base_path: PropTypes.string.isRequired,
4351
course_size: PropTypes.number.isRequired,
4452
};

src/components/lesson/LessonLink.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ const LessonLink = ({ title, length, order, active, base_path }) => {
4141
LessonLink.propTypes = {
4242
title: PropTypes.string.isRequired,
4343
order: PropTypes.number.isRequired,
44-
length: PropTypes.number.isRequired,
44+
length: PropTypes.string.isRequired,
4545
active: PropTypes.bool.isRequired,
4646
base_path: PropTypes.string.isRequired,
4747
};

src/components/lesson/LessonsPane.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ LessonsPane.propTypes = {
2727
PropTypes.shape({
2828
order: PropTypes.number.isRequired,
2929
title: PropTypes.string.isRequired,
30-
length: PropTypes.number.isRequired,
30+
length: PropTypes.string.isRequired,
3131
}),
3232
).isRequired,
3333
base_path: PropTypes.string.isRequired,

src/components/pages/LessonPage.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ import '../../css/pages/LessonPage.scss';
66
function LessonPage(props) {
77
const { curr_lesson_num, lessons, base_path, course_title } = props;
88
// const { title, src, description, id } = lessons.find(elem => elem.id === activeId);
9-
// const { title, src, description, order } = lessons[curr_lesson_num];
109
const lesson = lessons[curr_lesson_num];
1110
const total = lessons.length;
1211

@@ -31,7 +30,7 @@ LessonPage.propTypes = {
3130
order: PropTypes.number.isRequired,
3231
title: PropTypes.string.isRequired,
3332
src: PropTypes.string.isRequired,
34-
length: PropTypes.number.isRequired,
33+
length: PropTypes.string.isRequired,
3534
description: PropTypes.string.isRequired,
3635
}),
3736
).isRequired,

0 commit comments

Comments
 (0)