review tweaks

Author: samsaksfithian

controllers/index.js

@@ -4,5 +4,5 @@
 module.exports.lesson = require('./lessonController');
 module.exports.course = require('./courseController');
 module.exports.path = require('./pathController');
-module.exports.user = require('./user');
-module.exports.nested_data = require('./nested-data');
+module.exports.user = require('./userController');
+module.exports.nested_data = require('./nestedDataController');

db/seedContent.js

@@ -137,7 +137,7 @@ async function seedContent(seed_data) {
   // now path_funcs are all executed, so course_funcs now full of callbacks, lesson_funcs still empty
   await Promise.all(course_funcs.map(courseFunc => courseFunc()));
   console.log('Finished seeding all courses');
-  // now path)funcs and course_funcs all executed, lesson_funcs now full of callbacks
+  // now path_funcs and course_funcs all executed, lesson_funcs now full of callbacks
   await Promise.all(lesson_funcs.map(lessonFunc => lessonFunc()));
   // now all functions have been executed
   console.log('Finished seeding all lessons');

models/index.js

@@ -45,8 +45,8 @@ const CandidateLesson = CandidateLessonsModel(sequelize, Sequelize);
 // https://sequelize.org/master/manual/associations.html
 // User.belongsTo(Persona, { foreignKey: 'personaType', targetKey: 'type' });
 // Persona.hasMany(User, { foreignKey: 'personaType', sourceKey: 'type' });
-Persona.belongsTo(Permission);
-Permission.hasMany(Persona);
+// Persona.belongsTo(Permission);
+// Permission.hasMany(Persona);
 // Candidate.belongsTo(Question);
 // Question.hasMany(Candidate);
 // Candidate.belongsTo(Recruiter, { foreignKey: 'contactedBy' });

utils/transformers.js

@@ -15,7 +15,7 @@ function parseDuration(duration) {
   const time_pattern = `T(?<hours>${numbers}H)?(?<minutes>${numbers}M)?(?<seconds>${numbers}S)?`;
   const iso8601 = new RegExp(`${period_pattern}${time_pattern}`);
   const { groups } = duration.match(iso8601);
-  // coefficients to convert a time unit to the next smaller time unit
+  // coefficients to convert a time unit to the next smaller time unit down to a minimum of seconds
   const reduce_unit_coeffs = {
     years: 12,
     months: 4,