Commit 3a7ea6d
committed
Do not build qcheck tests on OCaml 5
The expect test hardcode the RNG behavior of OCaml 4 and thus lead to
thousands of lines of failures.
Short excerpt:
#=== ERROR while compiling qcheck.0.18 ========================================#
# context 2.2.0~alpha~dev | linux/x86_64 | ocaml-base-compiler.5.0.0 | file:///home/opam/opam-repository
# path ~/.opam/5.0/.opam-switch/build/qcheck.0.18
# command ~/.opam/opam-init/hooks/sandbox.sh build dune runtest -p qcheck -j 47
# exit-code 1
# env-file ~/.opam/log/qcheck-7-cf6045.env
# output-file ~/.opam/log/qcheck-7-cf6045.out
### output ###
# File "example/output.txt.expected", line 1, characters 0-0:
# /usr/bin/git --no-pager diff --no-index --color=always -u _build/default/example/output.txt.expected _build/default/example/output.txt
# diff --git a/_build/default/example/output.txt.expected b/_build/default/example/output.txt
# index 2bcc615..ce4682e 100644
# --- a/_build/default/example/output.txt.expected
# +++ b/_build/default/example/output.txt
# @@ -2,13 +2,13 @@ random seed: 1234
#
# --- Failure --------------------------------------------------------------------
#
# -Test should_fail_sort_id failed (18 shrink steps):
# +Test should_fail_sort_id failed (12 shrink steps):
#
# [1; 0]
#
# === Error ======================================================================
#
# -Test should_error_raise_exn errored on (63 shrink steps):
# +Test should_error_raise_exn errored on (62 shrink steps):
#
# 0
#
# @@ -19,59 +19,59 @@ exception Dune__exe__QCheck_runner_test.Error
#
# Collect results for test collect_results:
#
# -4: 20 cases
# -3: 25 cases
# -2: 17 cases
# -1: 18 cases
# -0: 20 cases
# +4: 24 cases
# +3: 20 cases
# +2: 18 cases
# +1: 21 cases
# +0: 17 cases1 parent 2139366 commit 3a7ea6d
3 files changed
+4
-4
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
15 | | - | |
| 15 | + | |
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
15 | | - | |
| 15 | + | |
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
26 | | - | |
| 26 | + | |
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
| |||
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
35 | | - | |
| 35 | + | |
0 commit comments