Skip to content

Commit 5ac5522

Browse files
Add build field to XML-Light 2.4
The current instructions are missing a `build` field (that `xml-light.2.3` has). It works because the `install` field uses the `install_ocamlfind` target which depends on `all` and `opt` but it seems a bit inelegant to build in the `install` step. This was detected as opam-monorepo classifies packages without `build` instructions as packages without a source, which is not the case for `xml-light`. A PR exists tarides/opam-monorepo#376 but there is the question whether missing `build` steps is a packaging mistake or not. In any case, this PR is a proposal to fix the issue and I'm looking forward to hear the input of opam-repository maintainers on this question.
1 parent ffef637 commit 5ac5522

File tree

1 file changed

+4
-0
lines changed
  • packages/xml-light/xml-light.2.4

1 file changed

+4
-0
lines changed

packages/xml-light/xml-light.2.4/opam

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,10 @@ depends: [
66
"ocamlfind"
77
]
88
dev-repo: "git+https://github.com/ncannasse/xml-light"
9+
build: [
10+
[make "all"]
11+
[make "opt"]
12+
]
913
install: [make "install_ocamlfind"]
1014
synopsis: "Xml-Light is a minimal XML parser & printer for OCaml"
1115
description: """

0 commit comments

Comments
 (0)