feat: update default attributes

Author: Hidetaka Okamoto

src/PersistentAttributesManager/PersistentAttributesManager.service.ts

@@ -34,7 +34,7 @@ export class PersistentAttributesManager<
   private static instance: PersistentAttributesManager;
   private readonly logger: Logger = new DefaultLogger();
   private hasUpdated: boolean = false;
-  protected readonly defaultAttributes?: T = undefined
+  protected readonly defaultAttributes?: T = undefined;
 
   public static getInstance<
     T extends PersistentAttributes = PersistentAttributes
@@ -50,7 +50,9 @@ export class PersistentAttributesManager<
     this.attributeManager = attributesManager;
   }
 
-  public async getPersistentAttributes(defaultAttributes?: Partial<T>): Promise<T> {
+  public async getPersistentAttributes(
+    defaultAttributes?: Partial<T>
+  ): Promise<T> {
     try {
       const data = await this.attributeManager.getPersistentAttributes();
       if (data) {
@@ -60,7 +62,7 @@ export class PersistentAttributesManager<
           ...data,
         } as T;
         this.attributeManager.setPersistentAttributes(item);
-        return item
+        return item;
       }
     } catch (e) {
       this.logger.debug(e.name);
@@ -69,9 +71,9 @@ export class PersistentAttributesManager<
     const defaultAtts = {
       ...this.defaultAttributes,
       ...defaultAttributes,
-    } as T
+    } as T;
     this.attributeManager.setPersistentAttributes(defaultAtts);
-    return defaultAtts
+    return defaultAtts;
   }
 
   /**
@@ -87,7 +89,9 @@ export class PersistentAttributesManager<
    *  await persistentAttributesManager.save()
    *  ```
    */
-  public async updatePersistentAttributes(attributes: Partial<T>): Promise<void> {
+  public async updatePersistentAttributes(
+    attributes: Partial<T>
+  ): Promise<void> {
     try {
       const data = await this.attributeManager.getPersistentAttributes();
       this.attributeManager.setPersistentAttributes(

src/PersistentAttributesManager/__tests__/PersistanteAttributesManager.service.spec.ts

@@ -47,83 +47,83 @@ describe('PersistenteAttributesManager.service.ts', () => {
     type TestTypes = {
       name: string;
       count: number;
-    }
+    };
     class ExtendClass extends PersistentAttributesManager<TestTypes> {
       protected readonly defaultAttributes = {
         name: 'john',
-        count: 0
-      }
+        count: 0,
+      };
     }
-    let target: ExtendClass
+    let target: ExtendClass;
     beforeEach(() => {
       adapter = new MockPersistenceAdapter();
       handlerInput = new HandlerInputFactory(
         new RequestEnvelopeFactory(new LaunchRequestFactory())
       )
         .setPersistanceAdapter(adapter)
         .create();
-      target = new ExtendClass(handlerInput.attributesManager)
-    })
+      target = new ExtendClass(handlerInput.attributesManager);
+    });
     it('should get default value', async () => {
-      const attributes = await target.getPersistentAttributes()
+      const attributes = await target.getPersistentAttributes();
       expect(attributes).toEqual({
         name: 'john',
-        count: 0
-      })
-    })
+        count: 0,
+      });
+    });
     it('should get overwritten default value', async () => {
       const attributes = await target.getPersistentAttributes({
-        count: 2
-      })
+        count: 2,
+      });
       expect(attributes).toEqual({
         name: 'john',
-        count: 2
-      })
-    })
+        count: 2,
+      });
+    });
     it('should get overwritten default value', async () => {
       const attributes = await target.getPersistentAttributes({
-        count: 2
-      })
+        count: 2,
+      });
       expect(attributes).toEqual({
         name: 'john',
-        count: 2
-      })
-    })
+        count: 2,
+      });
+    });
     it('should not saved default atts when does not call save', async () => {
       handlerInput2 = new HandlerInputFactory(
         new RequestEnvelopeFactory(new LaunchRequestFactory())
       )
         .setPersistanceAdapter(adapter)
         .create();
-      const target2 = new ExtendClass(handlerInput2.attributesManager)
+      const target2 = new ExtendClass(handlerInput2.attributesManager);
       await target.getPersistentAttributes({
-        count: 2
-      })
-      const attributes = await target2.getPersistentAttributes()
+        count: 2,
+      });
+      const attributes = await target2.getPersistentAttributes();
       expect(attributes).toEqual({
         name: 'john',
-        count: 0
-      })
-    })
+        count: 0,
+      });
+    });
     it('should saved default atts when call save', async () => {
       handlerInput2 = new HandlerInputFactory(
         new RequestEnvelopeFactory(new LaunchRequestFactory())
       )
         .setPersistanceAdapter(adapter)
         .create();
-      const target2 = new ExtendClass(handlerInput2.attributesManager)
-      const att =await target.getPersistentAttributes({
-        count: 2
-      })
-      await target.updatePersistentAttributes(att)
-      await target.save()
-      const attributes = await target2.getPersistentAttributes()
+      const target2 = new ExtendClass(handlerInput2.attributesManager);
+      const att = await target.getPersistentAttributes({
+        count: 2,
+      });
+      await target.updatePersistentAttributes(att);
+      await target.save();
+      const attributes = await target2.getPersistentAttributes();
       expect(attributes).toEqual({
         name: 'john',
-        count: 2
-      })
-    })
-  })
+        count: 2,
+      });
+    });
+  });
 
   describe('Class method test', () => {
     it('| should not save adn get persisted attributes without execute save method', async () => {

src/framework/__tests__/SkillFactory.class.spec.ts

@@ -260,4 +260,4 @@ describe('SkillFactoryr', () => {
       });
     });
   });
-});
+});