feat(ci): add prettier to ci

Author: tompsota

.eslintignore

@@ -0,0 +1,2 @@
+node_modules/
+lib/

.eslintrc.json

@@ -0,0 +1,20 @@
+{
+  "root": true,
+  "extends": [
+    "@react-native-community",
+    "prettier"
+  ],
+  "rules": {
+    "prettier/prettier": [
+      "error",
+      {
+        "quoteProps": "consistent",
+        "singleQuote": true,
+        "tabWidth": 2,
+        "trailingComma": "es5",
+        "useTabs": false
+      }
+    ],
+    "no-alert": "off"
+  }
+}

.github/workflows/ci.yml

@@ -18,7 +18,7 @@ jobs:
         uses: ./.github/actions/setup
 
       - name: Lint files
-        run: yarn lint
+        run: yarn lint --max-warnings=0
 
       - name: Typecheck files
         run: |
@@ -28,6 +28,9 @@ jobs:
         run: |
           yarn expo:typecheck
 
+      - name: Format check
+        run: yarn prettier --check
+
   # no tests yet 😥
   # test:
   #   runs-on: ubuntu-latest

.prettierignore

@@ -1 +1,2 @@
-plugin/build
+plugin/build
+lib/

example/src/MalwareItem.tsx

@@ -45,11 +45,7 @@ export const MalwareItem: React.FC<{ app: SuspiciousAppInfo }> = ({ app }) => {
           <View style={styles.buttonView}>
             <Image
               source={expanded ? ArrowUp : ArrowDown}
-              style={{
-                tintColor: Colors.grey,
-                width: 30,
-                height: 30,
-              }}
+              style={styles.expandArrow}
             />
           </View>
         </HStack>
@@ -88,8 +84,8 @@ export const MalwareItem: React.FC<{ app: SuspiciousAppInfo }> = ({ app }) => {
             <Button
               title={'Add to whitelist'}
               onPress={() => whitelistApp(app.packageInfo.packageName)}
-            ></Button>
-            <Button title={'Uninstall'} onPress={appUninstall}></Button>
+            />
+            <Button title={'Uninstall'} onPress={appUninstall} />
           </HStack>
         </>
       )}
@@ -154,4 +150,9 @@ const styles = StyleSheet.create({
     marginTop: 10,
     justifyContent: 'space-between',
   },
+  expandArrow: {
+    tintColor: Colors.grey,
+    width: 30,
+    height: 30,
+  },
 });

package.json

@@ -11,6 +11,7 @@
     "typecheck": "tsc --noEmit",
     "expo:typecheck": "cd plugin && tsc --noEmit",
     "lint": "eslint \"**/*.{js,ts,tsx}\"",
+    "prettier": "prettier \"**/*.{ts,js}\"",
     "prepack": "bob build && yarn build:plugin",
     "build": "bob build",
     "example": "yarn --cwd example",
@@ -94,29 +95,6 @@
       }
     }
   },
-  "eslintConfig": {
-    "root": true,
-    "extends": [
-      "@react-native-community",
-      "prettier"
-    ],
-    "rules": {
-      "prettier/prettier": [
-        "error",
-        {
-          "quoteProps": "consistent",
-          "singleQuote": true,
-          "tabWidth": 2,
-          "trailingComma": "es5",
-          "useTabs": false
-        }
-      ]
-    }
-  },
-  "eslintIgnore": [
-    "node_modules/",
-    "lib/"
-  ],
   "prettier": {
     "quoteProps": "consistent",
     "singleQuote": true,