AO3-7022 Default to only registered commentors on news post (otwcode#5247)

* AO3-7022 Default to only registered commentors on news post

* Fix tests

* Extend test to verify new default

Author: brianjaustin

app/models/admin_post.rb

@@ -6,7 +6,7 @@ class AdminPost < ApplicationRecord
     enable_all: 0,
     disable_anon: 1,
     disable_all: 2
-  }, _suffix: :comments
+  }, _default: :disable_anon, _suffix: :comments
 
   belongs_to :language
   belongs_to :translated_post, class_name: "AdminPost"

factories/comments.rb

@@ -13,7 +13,7 @@
     end
 
     trait :on_admin_post do
-      commentable { create(:admin_post) }
+      commentable { create(:admin_post, comment_permissions: :enable_all) }
     end
 
     trait :on_tag do

features/admins/admin_post_news.feature

@@ -37,27 +37,6 @@ Feature: Admin Actions to Post News
     Then 0 emails should be delivered to "testadmin-communications@example.org"
       But 1 email should be delivered to "admin@example.org"
 
-  Scenario: Evil user can impersonate admin in comments
-  # However, they can't use an icon, so the admin's icon is the guarantee that they're real
-  # also their username will be plain text and not a link
-
-    Given I have posted an admin post
-    When I am logged in as "happyuser"
-      And I go to the admin-posts page
-    When I follow "Default Admin Post"
-      And I fill in "Comment" with "Excellent, my dear!"
-      And I press "Comment"
-    When I log out
-      And I go to the admin-posts page
-      And I follow "Default Admin Post"
-      And I fill in "Comment" with "Behold, ye mighty, and despair!"
-      And I fill in "Guest name" with "admin"
-      And I fill in "Guest email" with "admin@example.com"
-      And I press "Comment"
-    Then I should see "Comment created!"
-      And I should see "admin"
-      And I should see "Behold, ye mighty, and despair!"
-
   Scenario: User views RSS of admin posts
 
     Given I have posted an admin post
@@ -249,6 +228,7 @@ Feature: Admin Actions to Post News
     Given I am logged in as a "communications" admin
     When I start to make an admin post
       And I check "Enable comment moderation"
+      And I choose "Registered users and guests can comment"
       And I press "Post"
     Then I should see "Admin Post was successfully created."
       And I should not see "Unreviewed Comments"

features/comments_and_kudos/comments_adminposts.feature

@@ -117,14 +117,19 @@ Feature: Commenting on admin posts
     Given I have posted an admin post
       And basic languages
       And I am logged in as a "translation" admin
-    When I make a translation of an admin post
-      And I follow "Back to AO3 News Index"
-      And I follow "Edit"
-      And I choose "Only registered users can comment"
-      And I press "Post"
+      And I make a translation of an admin post
+    When I follow "Back to AO3 News Index"
+      And I follow "Show"
     Then I should see "Sorry, this news post doesn't allow non-Archive users to comment."
     When I follow "Deutsch"
     Then I should see "Sorry, this news post doesn't allow non-Archive users to comment."
+    When I follow "Back to AO3 News Index"
+      And I follow "Edit"
+      And I choose "Registered users and guests can comment"
+      And I press "Post"
+    Then I should see "Please log out of your admin account to comment."
+    When I follow "Deutsch"
+    Then I should see "Please log out of your admin account to comment."
 
   Scenario: Translation of admin post with comments disabled
     Given I have posted an admin post with comments disabled

features/step_definitions/admin_steps.rb

@@ -127,7 +127,7 @@
 end
 
 Given "the admin post {string}" do |title|
-  FactoryBot.create(:admin_post, title: title)
+  FactoryBot.create(:admin_post, title: title, comment_permissions: :enable_all)
 end
 
 Given "the fannish next of kin {string} for the user {string}" do |kin, user|

spec/controllers/comments/default_rails_actions_spec.rb

@@ -18,7 +18,7 @@
     end
 
     it "renders the :new template if commentable is a valid admin post" do
-        admin_post = create(:admin_post)
+        admin_post = create(:admin_post, comment_permissions: :enable_all)
         get :new, params: { admin_post_id: admin_post.id }
         expect(response).to render_template("new")
         expect(assigns(:name)).to eq(admin_post.title)