Skip to content

Commit ba22585

Browse files
authored
AO3-6807 Fix offer URL capitalisation in errors (otwcode#5235)
* AO3-6807 Fix offer URL capitalisation in errors * Attempted flaky text fix
1 parent a5c1f04 commit ba22585

File tree

3 files changed

+19
-3
lines changed

3 files changed

+19
-3
lines changed

config/locales/models/en.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@ en:
1616
support: Support
1717
tag_wrangling: Tag Wrangling
1818
translation: Translation
19+
challenge_signup/offers:
20+
url: Offer URL
1921
challenge_signup/requests:
2022
url: Request URL
2123
chapters/creatorships:
@@ -37,6 +39,8 @@ en:
3739
meta_tag_id: Metatag
3840
sub_tag: Subtag
3941
sub_tag_id: Subtag
42+
offer:
43+
url: URL
4044
request:
4145
url: URL
4246
role:

features/gift_exchanges/challenge_giftexchange.feature

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ Feature: Gift Exchange Challenge
120120
And I submit
121121
Then I should see "URL: https://example.com/url_for_prompt"
122122

123-
Scenario: Invalid URL is disallowed when editing a signup
123+
Scenario: Invalid URL is disallowed when editing a request in a signup
124124
Given the gift exchange "Awesome Gift Exchange" is ready for signups
125125
And I edit settings for "Awesome Gift Exchange" challenge
126126
And I check "gift_exchange[request_restriction_attributes][url_allowed]"
@@ -132,6 +132,18 @@ Feature: Gift Exchange Challenge
132132
And I submit
133133
Then I should see "Request URL does not appear to be a valid URL."
134134

135+
Scenario: Invalid URL is disallowed when editing an offer in a signup
136+
Given the gift exchange "Awesome Gift Exchange" is ready for signups
137+
And I edit settings for "Awesome Gift Exchange" challenge
138+
And I check "gift_exchange[offer_restriction_attributes][url_allowed]"
139+
And I submit
140+
When I am logged in as "myname1"
141+
And I sign up for "Awesome Gift Exchange" with combination A
142+
And I follow "Edit Sign-up"
143+
And I fill in "Prompt URL:" with "i hereby offer you a bug."
144+
And I submit
145+
Then I should see "Offer URL does not appear to be a valid URL."
146+
135147
Scenario: Sign-ups can be seen in the dashboard
136148
Given the gift exchange "Awesome Gift Exchange" is ready for signups
137149
When I am logged in as "myname1"

features/other_b/skin.feature

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -334,8 +334,8 @@ Feature: Non-public site and work skins
334334

335335
@javascript
336336
Scenario: User can add a parent skin using the Custom CSS form
337-
Given I am logged in
338-
And I create the skin "Dad"
337+
Given the skin "Dad" by "skinner"
338+
And I am logged in as "skinner"
339339
When I go to the new skin page
340340
Then I should see "Advanced"
341341
When I follow "Show ↓"

0 commit comments

Comments
 (0)