update

Author: tamedevelopers

src/Capsule/Artisan.php

@@ -118,6 +118,10 @@ public function run(array $argv): int
         // Ensure external commands are discovered even if constructed elsewhere
         $this->discoverExternal();
 
+        dd(
+            $this->resolveVendorPath()
+        );
+
         if ($commandInput === 'list') {
             $this->renderList();
             return 0;

src/Capsule/Traits/ArtisanDiscovery.php

@@ -119,50 +119,8 @@ private function discoverExternal(): void
 
                 try {
                     $provider = new $fqcn();
-                    $didRegister = false;
-
-                    // Preferred: provider explicitly implements our interface
-                    if ($provider instanceof \Tamedevelopers\Support\Capsule\CommandProviderInterface) {
+                    if (method_exists($provider, 'register')) {
                         $provider->register($this);
-                        $didRegister = true;
-                    }
-                    // Fallback: detect register() signature and call appropriately
-                    elseif (method_exists($provider, 'register')) {
-                        try {
-                            $rm = new \ReflectionMethod($provider, 'register');
-                            $paramCount = $rm->getNumberOfParameters();
-
-                            if ($paramCount === 0) {
-                                // Laravel-like providers often have register() with no args
-                                $provider->register();
-                                $didRegister = true;
-                            } else {
-                                // If first param accepts our Artisan (or is untyped/mixed/optional), pass it
-                                $first = $rm->getParameters()[0];
-                                $canPassArtisan = true;
-
-                                if ($first->hasType()) {
-                                    $t = $first->getType();
-                                    if ($t instanceof \ReflectionNamedType) {
-                                        $name = ltrim($t->getName(), '\\');
-                                        $canPassArtisan = ($name === 'Tamedevelopers\\Support\\Capsule\\Artisan') || ($name === 'mixed') || ($name === 'array') || ($name === 'object');
-                                    }
-                                }
-
-                                if ($canPassArtisan) {
-                                    $provider->register($this);
-                                    $didRegister = true;
-                                } elseif ($first->isOptional()) {
-                                    $provider->register();
-                                    $didRegister = true;
-                                }
-                            }
-                        } catch (\Throwable $ignored) {
-                            // If reflection or calling fails, we just skip this provider
-                        }
-                    }
-
-                    if ($didRegister) {
                         self::$registeredProviders[$fqcn] = true;
                     }
                 } catch (\Throwable $e) {
@@ -173,34 +131,23 @@ private function discoverExternal(): void
     }
 
     /**
-     * Resolve the vendor directory path robustly for both:
-     * - Developing this package as the root project (support/vendor)
-     * - When installed inside another project (project/vendor)
+     * Resolve the vendor directory path for both dev (package root) and consumer app.
      */
     private function resolveVendorPath(): ?string
     {
-        // Start from this file's directory and walk upwards to find:
-        // - a 'vendor' directory sibling (e.g., support/vendor), or
-        // - a parent directory named 'vendor' (e.g., project/vendor)
-        $dir = __DIR__;
-
-        for ($i = 0; $i < 8; $i++) {
-            if ($dir === DIRECTORY_SEPARATOR || $dir === '/' || $dir === '') {
-                break;
-            }
+        // Current file: support/Capsule/Traits/ArtisanDiscovery.php
+        $packageRoot = \dirname(__DIR__, 3); // .../support
 
-            // Case A: current directory is the vendor directory
-            if (\basename($dir) === 'vendor' && \is_dir($dir)) {
-                return $dir;
-            }
-
-            // Case B: there is a vendor directory inside the current directory
-            $candidate = $dir . DIRECTORY_SEPARATOR . 'vendor';
-            if (\is_dir($candidate)) {
-                return $candidate;
-            }
+        // Case 1: developing this package as the root project
+        $vendor = $packageRoot . DIRECTORY_SEPARATOR . 'vendor';
+        if (is_dir($vendor)) {
+            return $vendor;
+        }
 
-            $dir = \dirname($dir);
+        // Case 2: this package is installed as a dependency: project/vendor/tamedevelopers/support/...
+        $maybeProjectVendor = \dirname($packageRoot, 2); // .../project/vendor
+        if (is_dir($maybeProjectVendor)) {
+            return $maybeProjectVendor;
         }
 
         return null;