Skip to content

Commit 1fb65a0

Browse files
Merge branch 'main' into add-generate-workflows-info
2 parents b3e6e84 + 4606cf2 commit 1fb65a0

File tree

8 files changed

+12
-9
lines changed

8 files changed

+12
-9
lines changed

.github/component_owners.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,4 +71,5 @@ components:
7171
- karthikscale3
7272
- lmolkova
7373
- lzchen
74+
- gyliu513
7475
- nirga

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
2020

2121
### Breaking changes
2222

23+
- `opentelemetry-instrumentation-sqlalchemy` teach instruments version
24+
([#2971](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/2971))
2325
- Drop `opentelemetry-instrumentation-test` package from default instrumentation list
2426
([#2969](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/2969))
2527

CONTRIBUTING.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ Please also read the [OpenTelemetry Contributor Guide](https://github.com/open-t
3434
* [Testing against a different Core repo branch/commit](#testing-against-a-different-core-repo-branchcommit)
3535
* [Style Guide](#style-guide)
3636
* [Guideline for instrumentations](#guideline-for-instrumentations)
37-
* [Guidance for GenAI instrumentations](#guideline-for-genai-instrumentations)
37+
* [Guideline for GenAI instrumentations](#guideline-for-genai-instrumentations)
3838
* [Expectations from contributors](#expectations-from-contributors)
3939

4040
## Find a Buddy and get Started Quickly
@@ -274,13 +274,13 @@ Below is a checklist of things to be mindful of when implementing a new instrume
274274
- ex. <https://github.com/open-telemetry/opentelemetry-python-contrib/blob/60fb936b7e5371b3e5587074906c49fb873cbd76/instrumentation/opentelemetry-instrumentation-grpc/tests/test_aio_server_interceptor.py#L84>
275275
- All instrumentations have the same version. If you are going to develop a new instrumentation it would probably have `X.Y.dev` version and depends on `opentelemetry-instrumentation` and `opentelemetry-semantic-conventions` for the same version. That means that if you want to install your instrumentation you need to install its dependencies from this repo and the core repo also from git.
276276

277-
## Guidance for GenAI instrumentations
277+
## Guideline for GenAI instrumentations
278278

279-
Instrumentations that relate to [Generative AI](https://opentelemetry.io/docs/specs/semconv/gen-ai/) systems will be placed in the [genai](./instrumentation/genai) folder. This section covers contributions related to those instrumentations. Please note that the [guidelines for instrumentations](#guideline-for-instrumentations) and [expectations from contributors](#expectations-from-contributors) still apply.
279+
Instrumentations that relate to [Generative AI](https://opentelemetry.io/docs/specs/semconv/gen-ai/) systems will be placed in the [instrumentation-genai](./instrumentation-genai) folder. This section covers contributions related to those instrumentations. Please note that the [guidelines for instrumentations](#guideline-for-instrumentations) and [expectations from contributors](#expectations-from-contributors) still apply.
280280

281281
### Get Involved
282282

283-
* Reviewing PRs: If you would like to be tagged as reviewer in new PRs related to these instrumentations, please submit a PR to add your GitHub handle to [component_owners.yml](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/2944/.github/component_owners.yml) under the corresponding instrumentation folder(s).
283+
* Reviewing PRs: If you would like to be tagged as reviewer in new PRs related to these instrumentations, please submit a PR to add your GitHub handle to [component_owners.yml](https://github.com/open-telemetry/opentelemetry-python-contrib/blob/main/.github/component_owners.yml) under the corresponding instrumentation folder(s).
284284

285285
* Approving PRs: If you would like to be able to approve PRs related to these instrumentations, you must join [opentelemetry-python-contrib-approvers](https://github.com/orgs/open-telemetry/teams/opentelemetry-python-contrib-approvers) team. Please ask one of the [Python contrib maintainers](https://github.com/orgs/open-telemetry/teams/opentelemetry-python-contrib-maintainers) to be accepted into the team.
286286

instrumentation-genai/opentelemetry-instrumentation-openai-v2/CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
77

88
## Unreleased
99

10-
## Version 2.0b0 (2024-11-05)
10+
## Version 2.0b0 (2024-11-08)
1111

1212
- Use generic `OTEL_INSTRUMENTATION_GENAI_CAPTURE_MESSAGE_CONTENT` environment variable
1313
to control if content of prompt, completion, and other messages is captured.

instrumentation/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939
| [opentelemetry-instrumentation-redis](./opentelemetry-instrumentation-redis) | redis >= 2.6 | No | experimental
4040
| [opentelemetry-instrumentation-remoulade](./opentelemetry-instrumentation-remoulade) | remoulade >= 0.50 | No | experimental
4141
| [opentelemetry-instrumentation-requests](./opentelemetry-instrumentation-requests) | requests ~= 2.0 | Yes | migration
42-
| [opentelemetry-instrumentation-sqlalchemy](./opentelemetry-instrumentation-sqlalchemy) | sqlalchemy | Yes | experimental
42+
| [opentelemetry-instrumentation-sqlalchemy](./opentelemetry-instrumentation-sqlalchemy) | sqlalchemy >= 1.0.0, < 2.1.0 | Yes | experimental
4343
| [opentelemetry-instrumentation-sqlite3](./opentelemetry-instrumentation-sqlite3) | sqlite3 | No | experimental
4444
| [opentelemetry-instrumentation-starlette](./opentelemetry-instrumentation-starlette) | starlette ~= 0.13.0 | Yes | experimental
4545
| [opentelemetry-instrumentation-system-metrics](./opentelemetry-instrumentation-system-metrics) | psutil >= 5 | No | experimental

instrumentation/opentelemetry-instrumentation-sqlalchemy/pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ dependencies = [
3434

3535
[project.optional-dependencies]
3636
instruments = [
37-
"sqlalchemy",
37+
"sqlalchemy >= 1.0.0, < 2.1.0",
3838
]
3939

4040
[project.entry-points.opentelemetry_instrumentor]

instrumentation/opentelemetry-instrumentation-sqlalchemy/src/opentelemetry/instrumentation/sqlalchemy/package.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,6 @@
1212
# See the License for the specific language governing permissions and
1313
# limitations under the License.
1414

15-
_instruments = ("sqlalchemy",)
15+
_instruments = ("sqlalchemy >= 1.0.0, < 2.1.0",)
1616

1717
_supports_metrics = True

opentelemetry-instrumentation/src/opentelemetry/instrumentation/bootstrap_gen.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@
161161
"instrumentation": "opentelemetry-instrumentation-requests==0.50b0.dev",
162162
},
163163
{
164-
"library": "sqlalchemy",
164+
"library": "sqlalchemy >= 1.0.0, < 2.1.0",
165165
"instrumentation": "opentelemetry-instrumentation-sqlalchemy==0.50b0.dev",
166166
},
167167
{

0 commit comments

Comments
 (0)