Skip to content

Commit 3c43604

Browse files
Add _DB_DRIVER_ALIASES
1 parent 224a771 commit 3c43604

File tree

1 file changed

+12
-2
lines changed
  • instrumentation/opentelemetry-instrumentation-dbapi/src/opentelemetry/instrumentation/dbapi

1 file changed

+12
-2
lines changed

instrumentation/opentelemetry-instrumentation-dbapi/src/opentelemetry/instrumentation/dbapi/__init__.py

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,11 @@
5353
)
5454
from opentelemetry.semconv.trace import SpanAttributes
5555
from opentelemetry.trace import SpanKind, TracerProvider, get_tracer
56+
from opentelemetry.util._importlib_metadata import version
57+
58+
_DB_DRIVER_ALIASES = {
59+
"MySQLdb": "mysqlclient",
60+
}
5661

5762
_logger = logging.getLogger(__name__)
5863

@@ -428,9 +433,14 @@ def traced_execution(
428433
try:
429434
args_list = list(args)
430435
db_driver = self._db_api_integration.connect_module.__name__
436+
db_version = ""
437+
if db_driver in _DB_DRIVER_ALIASES.keys():
438+
db_version = version(_DB_DRIVER_ALIASES[db_driver])
439+
else:
440+
db_version = self._db_api_integration.connect_module.__version__
441+
431442
commenter_data = {
432-
# TODO MySQLdb attribute
433-
"db_driver": f"{db_driver}:{self._connect_module.__version__.split(' ')[0]}",
443+
"db_driver": f"{db_driver}:{db_version.split(' ')[0]}",
434444
"dbapi_threadsafety": self._connect_module.threadsafety,
435445
"dbapi_level": self._connect_module.apilevel,
436446
"driver_paramstyle": self._connect_module.paramstyle,

0 commit comments

Comments
 (0)