lint

Author: tammy-baylis-swi

instrumentation/opentelemetry-instrumentation-tornado/src/opentelemetry/instrumentation/tornado/__init__.py

@@ -262,7 +262,7 @@ class TornadoInstrumentor(BaseInstrumentor):
     def instrumentation_dependencies(self) -> Collection[str]:
         return _instruments
 
-    def _instrument(self, **kwargs):
+    def _instrument(self, **kwargs):  # pylint: disable=too-many-locals
         """
         _instrument patches tornado.web.RequestHandler and tornado.httpclient.AsyncHTTPClient classes
         to automatically instrument requests both received and sent by Tornado.
@@ -282,7 +282,7 @@ def _instrument(self, **kwargs):
         Note that the patch does not apply on every single __init__ call, only the first one for the entire
         process lifetime.
         """
-        global _sem_conv_opt_in_mode
+        global _sem_conv_opt_in_mode  # pylint: disable=global-statement
 
         # Initialize semantic conventions opt-in mode
         _OpenTelemetrySemanticConventionStability._initialize()
@@ -370,7 +370,7 @@ def handler_init(init, handler, args, kwargs):
         )
 
     def _uninstrument(self, **kwargs):
-        global _sem_conv_opt_in_mode
+        global _sem_conv_opt_in_mode  # pylint: disable=global-statement
         _sem_conv_opt_in_mode = _StabilityMode.DEFAULT
 
         unwrap(tornado.web.RequestHandler, "__init__")

instrumentation/opentelemetry-instrumentation-tornado/src/opentelemetry/instrumentation/tornado/client.py

@@ -59,7 +59,7 @@ def _normalize_request(args, kwargs):
     return (new_args, new_kwargs)
 
 
-def fetch_async(
+def fetch_async(  # pylint: disable=too-many-locals
     tracer,
     request_hook,
     response_hook,
@@ -130,7 +130,7 @@ def fetch_async(
         return future
 
 
-def _finish_tracing_callback(
+def _finish_tracing_callback(  # pylint: disable=too-many-locals,too-many-branches
     future,
     span,
     response_hook,

instrumentation/opentelemetry-instrumentation-tornado/tests/test_instrumentation.py

@@ -77,7 +77,7 @@ def setUp(self):
             _OpenTelemetrySemanticConventionStability,
         )
 
-        _OpenTelemetrySemanticConventionStability._initialized = False
+        _OpenTelemetrySemanticConventionStability._initialized = False  # pylint: disable=protected-access
         TornadoInstrumentor().instrument(
             server_request_hook=getattr(self, "server_request_hook", None),
             client_request_hook=getattr(self, "client_request_hook", None),

instrumentation/opentelemetry-instrumentation-tornado/tests/test_metrics_instrumentation.py

@@ -300,20 +300,19 @@ def get_app(self):
         app = make_app(tracer)
         return app
 
-    def setUp(self):
-        super().setUp()
-
     def tearDown(self):
         TornadoInstrumentor().uninstrument()
         super().tearDown()
 
-    def _get_server_span(self, spans):
+    @staticmethod
+    def _get_server_span(spans):
         for span in spans:
             if span.kind == SpanKind.SERVER:
                 return span
         return None
 
-    def _get_client_span(self, spans):
+    @staticmethod
+    def _get_client_span(spans):
         for span in spans:
             if span.kind == SpanKind.CLIENT:
                 return span