Skip to content

Commit c461544

Browse files
Fix style
1 parent b40faf2 commit c461544

File tree

1 file changed

+15
-13
lines changed
  • instrumentation/opentelemetry-instrumentation-dbapi/src/opentelemetry/instrumentation/dbapi

1 file changed

+15
-13
lines changed

instrumentation/opentelemetry-instrumentation-dbapi/src/opentelemetry/instrumentation/dbapi/__init__.py

Lines changed: 15 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -282,26 +282,28 @@ def __init__(
282282
self.connect_module = connect_module
283283
self.commenter_data = self.calculate_commenter_data()
284284

285+
def _get_db_version(
286+
self,
287+
db_driver,
288+
):
289+
if db_driver in _DB_DRIVER_ALIASES:
290+
return util_version(_DB_DRIVER_ALIASES[db_driver])
291+
db_version = ""
292+
try:
293+
db_version = self.connect_module.__version__
294+
except AttributeError:
295+
db_version = "unknown"
296+
return db_version
297+
285298
def calculate_commenter_data(
286299
self,
287300
):
288301
commenter_data = {}
289302
if not self.enable_commenter:
290303
return commenter_data
291304

292-
try:
293-
db_driver = self.connect_module.__name__
294-
except AttributeError:
295-
db_driver = "unknown"
296-
297-
db_version = ""
298-
if db_driver in _DB_DRIVER_ALIASES:
299-
db_version = util_version(_DB_DRIVER_ALIASES[db_driver])
300-
else:
301-
try:
302-
db_version = self.connect_module.__version__
303-
except AttributeError:
304-
db_version = "unknown"
305+
db_driver = getattr(self.connect_module, "__name__", "unknown")
306+
db_version = self._get_db_version(db_driver)
305307

306308
commenter_data = {
307309
"db_driver": f"{db_driver}:{db_version.split(' ')[0]}",

0 commit comments

Comments
 (0)