Skip to content

Commit a0c817c

Browse files
Simplify test
1 parent 676d9ff commit a0c817c

File tree

1 file changed

+9
-18
lines changed

1 file changed

+9
-18
lines changed

opentelemetry-sdk/tests/logs/test_handler.py

Lines changed: 9 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -95,26 +95,17 @@ def test_log_flush_noop(self):
9595

9696
def test_log_record_no_span_context(self):
9797
processor, logger = set_up_test_logging(logging.WARNING)
98-
mock_context = Context()
99-
100-
with patch(
101-
"opentelemetry.sdk._logs._internal.get_current",
102-
return_value=mock_context,
103-
):
104-
# Assert emit gets called for warning message
105-
with self.assertLogs(level=logging.WARNING):
106-
logger.warning("Warning message")
98+
with self.assertLogs(level=logging.WARNING):
99+
logger.warning("Warning message")
107100

108-
log_record = processor.get_log_record(0)
101+
log_record = processor.get_log_record(0)
109102

110-
self.assertIsNotNone(log_record)
111-
self.assertEqual(
112-
log_record.trace_id, INVALID_SPAN_CONTEXT.trace_id
113-
)
114-
self.assertEqual(log_record.span_id, INVALID_SPAN_CONTEXT.span_id)
115-
self.assertEqual(
116-
log_record.trace_flags, INVALID_SPAN_CONTEXT.trace_flags
117-
)
103+
self.assertIsNotNone(log_record)
104+
self.assertEqual(log_record.trace_id, INVALID_SPAN_CONTEXT.trace_id)
105+
self.assertEqual(log_record.span_id, INVALID_SPAN_CONTEXT.span_id)
106+
self.assertEqual(
107+
log_record.trace_flags, INVALID_SPAN_CONTEXT.trace_flags
108+
)
118109

119110
def test_log_record_observed_timestamp(self):
120111
processor, logger = set_up_test_logging(logging.WARNING)

0 commit comments

Comments
 (0)