Skip to content

Commit d0fb920

Browse files
authored
Explain why edits from maintainers are needed (open-telemetry#4175)
1 parent 586bb06 commit d0fb920

File tree

1 file changed

+17
-0
lines changed

1 file changed

+17
-0
lines changed

CONTRIBUTING.md

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -224,6 +224,23 @@ updating the GitHub workflow to reference a PR in the Contrib repo
224224
* Trivial change (typo, cosmetic, doc, etc.) doesn't have to wait for one day.
225225
* Urgent fix can take exception as long as it has been actively communicated.
226226

227+
#### Allow edits from maintainers
228+
229+
Something _very important_ is to allow edits from maintainers when opening a PR. This will
230+
allow maintainers to rebase your PR against `main` which is necessary in order to merge
231+
your PR. You could do it yourself too, but keep in mind that every time another PR gets
232+
merged, your PR will require rebasing. Since only maintainers can merge your PR it is
233+
almost impossible for maintainers to find your PR just when it has been rebased by you so
234+
that it can be merged. Allowing maintainers to edit your PR also allows them to help you
235+
get your PR merged by making any minor fixes to solve any issue that while being unrelated
236+
to your PR, can still happen.
237+
238+
#### Fork from a personal Github account
239+
240+
Right now Github [does not allow](https://github.com/orgs/community/discussions/5634) PRs
241+
to be edited by maintainers if the corresponding repo fork exists in a Github organization.
242+
Please for this repo in a personal Github account instead.
243+
227244
One of the maintainers will merge the PR once it is **ready to merge**.
228245

229246
## Design Choices

0 commit comments

Comments
 (0)