Skip to content

Commit 4bb41be

Browse files
committed
Support GVK style dependencies in crank beta validate
Signed-off-by: Nic Cope <[email protected]>
1 parent 3743dfe commit 4bb41be

File tree

1 file changed

+8
-5
lines changed

1 file changed

+8
-5
lines changed

cmd/crank/beta/validate/manager.go

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -234,17 +234,20 @@ func (m *Manager) addDependencies(confs map[string]*metav1.Configuration) error
234234
m.confs[image] = cfg // update the configuration
235235
}
236236

237-
// TODO(negz): Handle apiVersion and kind
238-
deps := cfg.Spec.MetaSpec.DependsOn
237+
deps := cfg.Spec.DependsOn
239238
for _, dep := range deps {
240239
image := ""
241-
if dep.Configuration != nil { //nolint:gocritic // switch is not suitable here
240+
switch {
241+
case dep.Package != nil:
242+
image = *dep.Package
243+
case dep.Configuration != nil:
242244
image = *dep.Configuration
243-
} else if dep.Provider != nil {
245+
case dep.Provider != nil:
244246
image = *dep.Provider
245-
} else if dep.Function != nil {
247+
case dep.Function != nil:
246248
image = *dep.Function
247249
}
250+
248251
if len(image) > 0 {
249252
image = fmt.Sprintf(imageFmt, image, dep.Version)
250253
m.deps[image] = true

0 commit comments

Comments
 (0)