engine: fix misplaced Unlock

sttts · sttts · commit 962e11846903 · 2025-02-06T08:37:32.000+01:00
Signed-off-by: Dr. Stefan Schimanski &lt;stefan.schimanski@gmail.com&gt;
diff --git a/internal/engine/engine.go b/internal/engine/engine.go
@@ -258,7 +258,6 @@ func (e *ControllerEngine) Stop(ctx context.Context, name string) error {
 	// Stop the controller's watches.
 	for wid, w := range c.sources {
 		if err := w.Stop(ctx); err != nil {
-			c.mx.Unlock()
 			return errors.Wrapf(err, "cannot stop %q watch for %q", wid.Type, wid.GVK)
 		}
 		delete(c.sources, wid)

Original file line number	Diff line number	Diff line change
`@@ -258,7 +258,6 @@ func (e *ControllerEngine) Stop(ctx context.Context, name string) error {`
`258`	`258`	`// Stop the controller's watches.`
`259`	`259`	`for wid, w := range c.sources {`
`260`	`260`	`if err := w.Stop(ctx); err != nil {`
`261`		`- c.mx.Unlock()`
`262`	`261`	`return errors.Wrapf(err, "cannot stop %q watch for %q", wid.Type, wid.GVK)`
`263`	`262`	`}`
`264`	`263`	`delete(c.sources, wid)`