Merge pull request crossplane#6248 from jbw976/nokia-remove_composed_event

Remove Successfully composed resources event

Author: jbw976

internal/controller/apiextensions/composite/reconciler.go

@@ -640,7 +640,7 @@ func (r *Reconciler) Reconcile(ctx context.Context, req reconcile.Request) (reco
 		// considered synced (i.e. severe enough to return a ReconcileError) but
 		// they are severe enough that we probably shouldn't say we successfully
 		// composed resources.
-		r.record.Event(xr, event.Normal(reasonCompose, "Successfully composed resources"))
+		log.Debug("Successfully composed resources")
 	}
 
 	var unready []ComposedResource

internal/controller/apiextensions/composite/reconciler_test.go

@@ -749,15 +749,6 @@ func TestReconcile(t *testing.T) {
 								Annotations: map[string]string{},
 							},
 						},
-						eventArgs{
-							Kind: compositeKind,
-							Event: event.Event{
-								Type:        event.Type(corev1.EventTypeNormal),
-								Reason:      "ComposeResources",
-								Message:     "Successfully composed resources",
-								Annotations: map[string]string{},
-							},
-						},
 					)),
 					WithCompositeFinalizer(resource.NewNopFinalizer()),
 					WithCompositionSelector(CompositionSelectorFn(func(_ context.Context, cr resource.Composite) error {
@@ -1102,15 +1093,6 @@ func TestReconcile(t *testing.T) {
 								Annotations: map[string]string{},
 							},
 						},
-						eventArgs{
-							Kind: compositeKind,
-							Event: event.Event{
-								Type:        event.Type(corev1.EventTypeNormal),
-								Reason:      "ComposeResources",
-								Message:     "Successfully composed resources",
-								Annotations: map[string]string{},
-							},
-						},
 					)),
 					WithCompositeFinalizer(resource.NewNopFinalizer()),
 					WithCompositionSelector(CompositionSelectorFn(func(_ context.Context, cr resource.Composite) error {
@@ -1199,15 +1181,6 @@ func TestReconcile(t *testing.T) {
 								Annotations: map[string]string{},
 							},
 						},
-						eventArgs{
-							Kind: compositeKind,
-							Event: event.Event{
-								Type:        event.Type(corev1.EventTypeNormal),
-								Reason:      "ComposeResources",
-								Message:     "Successfully composed resources",
-								Annotations: map[string]string{},
-							},
-						},
 					)),
 					WithCompositeFinalizer(resource.NewNopFinalizer()),
 					WithCompositionSelector(CompositionSelectorFn(func(_ context.Context, cr resource.Composite) error {
@@ -1280,15 +1253,6 @@ func TestReconcile(t *testing.T) {
 								Annotations: map[string]string{},
 							},
 						},
-						eventArgs{
-							Kind: compositeKind,
-							Event: event.Event{
-								Type:        event.Type(corev1.EventTypeNormal),
-								Reason:      "ComposeResources",
-								Message:     "Successfully composed resources",
-								Annotations: map[string]string{},
-							},
-						},
 					)),
 					WithCompositeFinalizer(resource.NewNopFinalizer()),
 					WithCompositionSelector(CompositionSelectorFn(func(_ context.Context, cr resource.Composite) error {