fix: update credits pallet params (#1039)

* chore: format code

* chore: format code

* chore: format edition

* chore: build docker in ci

* chore: fix rust

* chore: fix branch

* chore: fix max rate per block

* chore: cleanup params

* chore: fix len

* chore: update tests

Author: 1xstj

pallets/credits/src/lib.rs

@@ -91,7 +91,6 @@ pub mod pallet {
 
 	// Move STORAGE_VERSION inside the pallet mod
 	const STORAGE_VERSION: StorageVersion = StorageVersion::new(2);
-	const MAX_RATE_PER_BLOCK: u128 = 1_000_000;
 
 	#[pallet::pallet]
 	#[pallet::without_storage_info]
@@ -153,6 +152,10 @@ pub mod pallet {
 		/// Type for the origin that is allowed to update stake tiers.
 		type ForceOrigin: frame_support::traits::EnsureOrigin<Self::RuntimeOrigin>;
 
+		/// The maximum rate per block for a stake tier.
+		#[pallet::constant]
+		type MaxRatePerBlock: Get<BalanceOf<Self>>;
+
 		/// The weight information for the pallet.
 		type WeightInfo: WeightInfo;
 	}
@@ -412,7 +415,7 @@ pub mod pallet {
 
 			// Validate that rates don't exceed maximum allowed value
 			for tier in &new_tiers {
-				let max_rate = BalanceOf::<T>::saturated_from(MAX_RATE_PER_BLOCK);
+				let max_rate = BalanceOf::<T>::saturated_from(T::MaxRatePerBlock::get());
 				ensure!(tier.rate_per_block <= max_rate, Error::<T>::RateTooHigh);
 			}
 
@@ -465,7 +468,7 @@ pub mod pallet {
 
 			// Validate that rates don't exceed maximum allowed value
 			for tier in &new_tiers {
-				let max_rate = BalanceOf::<T>::saturated_from(MAX_RATE_PER_BLOCK);
+				let max_rate = BalanceOf::<T>::saturated_from(T::MaxRatePerBlock::get());
 				ensure!(tier.rate_per_block <= max_rate, Error::<T>::RateTooHigh);
 			}
 

pallets/credits/src/mock.rs

@@ -534,11 +534,15 @@ impl pallet_multi_asset_delegation::Config for Runtime {
 parameter_types! {
 	#[derive(Default, Copy, Clone, Eq, PartialEq, RuntimeDebug, Encode, Decode, MaxEncodedLen, TypeInfo)]
 	#[cfg_attr(feature = "std", derive(serde::Serialize, serde::Deserialize))]
-	pub const MaxStakeTiers: u32 = 10;
+	pub const MaxStakeTiers: u32 = tangle_primitives::credits::MAX_STAKE_TIERS;
 
 	#[derive(Default, Copy, Clone, Eq, PartialEq, RuntimeDebug, Encode, Decode, MaxEncodedLen, TypeInfo)]
 	#[cfg_attr(feature = "std", derive(serde::Serialize, serde::Deserialize))]
 	pub const CreditBurnRecipient: Option<AccountId> = None;
+
+	#[derive(Default, Copy, Clone, Eq, PartialEq, RuntimeDebug, Encode, Decode, MaxEncodedLen, TypeInfo)]
+	#[cfg_attr(feature = "std", derive(serde::Serialize, serde::Deserialize))]
+	pub const MaxRatePerBlock: Balance = tangle_primitives::credits::MAX_RATE_PER_BLOCK;
 }
 
 impl pallet_credits::Config for Runtime {
@@ -547,11 +551,12 @@ impl pallet_credits::Config for Runtime {
 	type AssetId = AssetId;
 	type MultiAssetDelegationInfo = MultiAssetDelegation;
 	type BurnConversionRate = ConstU128<1000>;
-	type ClaimWindowBlocks = ConstU64<1000>;
+	type ClaimWindowBlocks = ConstU64<{ tangle_primitives::credits::CLAIM_WINDOW_BLOCKS }>;
 	type CreditBurnRecipient = CreditBurnRecipient;
-	type MaxOffchainAccountIdLength = ConstU32<100>;
+	type MaxOffchainAccountIdLength = ConstU32<1024>;
 	type MaxStakeTiers = MaxStakeTiers;
 	type ForceOrigin = frame_system::EnsureRoot<AccountId>;
+	type MaxRatePerBlock = MaxRatePerBlock;
 	type WeightInfo = ();
 }