Skip to content

Commit a2c5b8f

Browse files
authored
fix: Fix test failure due to error code change (prestodb#26565)
## Description PR prestodb#26553 changed the error code from `FUNCTION_IMPLEMENTATION_MISSING` to `NOT_SUPPORTED` where parameter isn't supported to reduce unnecessary retry. This PR fix the relevant test case to eliminate the test failure. ## Motivation and Context - Eliminate test failure ## Impact N/A ## Test Plan N/A ## Contributor checklist - [ ] Please make sure your submission complies with our [contributing guide](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md), in particular [code style](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#code-style) and [commit standards](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#commit-standards). - [ ] PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced. - [ ] Documented new properties (with its default value), SQL syntax, functions, or other functionality. - [ ] If release notes are required, they follow the [release notes guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines). - [ ] Adequate tests were added if applicable. - [ ] CI passed. - [ ] If adding new dependencies, verified they have an [OpenSSF Scorecard](https://securityscorecards.dev/#the-checks) score of 5.0 or higher (or obtained explicit TSC approval for lower scores). ## Release Notes ``` == NO RELEASE NOTE == ```
1 parent 8f11e50 commit a2c5b8f

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

presto-main-base/src/test/java/com/facebook/presto/operator/scalar/TestArrayNormalizeFunction.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
import static com.facebook.presto.common.type.RealType.REAL;
2323
import static com.facebook.presto.spi.StandardErrorCode.FUNCTION_IMPLEMENTATION_MISSING;
2424
import static com.facebook.presto.spi.StandardErrorCode.INVALID_FUNCTION_ARGUMENT;
25+
import static com.facebook.presto.spi.StandardErrorCode.NOT_SUPPORTED;
2526

2627
public class TestArrayNormalizeFunction
2728

@@ -93,7 +94,7 @@ public void testUnsupportedType()
9394
"Unsupported array element type for array_normalize function: integer");
9495
assertInvalidFunction(
9596
"array_normalize(ARRAY['a', 'b', 'c'], 'd')",
96-
FUNCTION_IMPLEMENTATION_MISSING,
97+
NOT_SUPPORTED,
9798
"Unsupported type parameters.*");
9899
}
99100

0 commit comments

Comments
 (0)