Skip to content

Commit 8478f46

Browse files
YulunWmeta-codesync[bot]
authored andcommitted
Switch to use new colltrace by default
Summary: As the new colltrace comes close to functionality compared to old colltrace, switch to use new CollTrace by default. A following diff will also enable CollTrace by default. The old colltrace will be deleted in 2.28. Reviewed By: SuhitK Differential Revision: D84476753 fbshipit-source-id: 5b8ba6783d923dded66cdb43723ad66622d6b07f
1 parent 39e7ac8 commit 8478f46

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

comms/utils/cvars/nccl_cvars.cc

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
// Copyright (c) Meta Platforms, Inc. and affiliates.
2-
// @generated SignedSource<<9faa9aa79e5e364340862b443258445f2a79d5fb>>
2+
// @generated SignedSource<<ac94e136092e7333fa672ce200679405c62d835a>>
33
// Automatically generated by ./comms/utils/cvars/extractcvars.py --- START
44
// DO NOT EDIT!!!
55

@@ -2310,9 +2310,9 @@ static void readCvarEnv() {
23102310
"NCCL_COLLTRACE_TRACE_CUDA_GRAPH");
23112311
}
23122312
NCCL_COLLTRACE_USE_NEW_COLLTRACE =
2313-
env2bool("NCCL_COLLTRACE_USE_NEW_COLLTRACE", "False");
2313+
env2bool("NCCL_COLLTRACE_USE_NEW_COLLTRACE", "True");
23142314
NCCL_COLLTRACE_USE_NEW_COLLTRACE_DEFAULT =
2315-
env2bool("NCCL_ENV_DO_NOT_SET", "False");
2315+
env2bool("NCCL_ENV_DO_NOT_SET", "True");
23162316

23172317
if (NCCL_COLLTRACE_USE_NEW_COLLTRACE_DEFAULT !=
23182318
NCCL_COLLTRACE_USE_NEW_COLLTRACE) {

comms/utils/cvars/nccl_cvars.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
// Copyright (c) Meta Platforms, Inc. and affiliates.
2-
// @generated SignedSource<<9faa9aa79e5e364340862b443258445f2a79d5fb>>
2+
// @generated SignedSource<<ac94e136092e7333fa672ce200679405c62d835a>>
33
// Automatically generated by ./comms/utils/cvars/extractcvars.py --- START
44
// DO NOT EDIT!!!
55

comms/utils/cvars/nccl_cvars.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2104,7 +2104,7 @@ cvars:
21042104
21052105
- name : NCCL_COLLTRACE_USE_NEW_COLLTRACE
21062106
type : bool
2107-
default : false
2107+
default : true
21082108
description : |-
21092109
Use new colltrace implementation. This is a temporary flag to enable
21102110
new colltrace implementation. We will remove this flag once the new

0 commit comments

Comments
 (0)