Fix clang-tidy issue with old STL

d-frey · d-frey · commit d9fb307d320b · 2018-01-03T22:27:44.000+01:00
diff --git a/src/test/json/big_list_of_naughty_strings.cpp b/src/test/json/big_list_of_naughty_strings.cpp
@@ -14,7 +14,7 @@
 std::string get_file_contents( const char* filename )
 {
    std::ifstream in( filename, std::ios::in | std::ios::binary );
-   if( in ) {
+   if( !in.fail() ) {
       std::string contents;
       in.seekg( 0, std::ios::end );
       contents.resize( static_cast< std::string::size_type >( in.tellg() ) );

Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@`
`14`	`14`	`std::string get_file_contents( const char* filename )`
`15`	`15`	`{`
`16`	`16`	`std::ifstream in( filename, std::ios::in \| std::ios::binary );`
`17`		`- if( in ) {`
	`17`	`+ if( !in.fail() ) {`
`18`	`18`	`std::string contents;`
`19`	`19`	`in.seekg( 0, std::ios::end );`
`20`	`20`	`contents.resize( static_cast< std::string::size_type >( in.tellg() ) );`