clang-tidy

Author: d-frey

include/tao/json/events/from_value.hpp

@@ -97,7 +97,7 @@ namespace tao::json::events
          case type::VALUELESS_BY_EXCEPTION:
             throw std::logic_error( "unable to produce events from valueless-by-exception value" );
       }
-      throw std::logic_error( internal::format( "invalid value '", static_cast< std::uint8_t >( v.type() ), "' for tao::json::type" ) );  // LCOV_EXCL_LINE
+      throw std::logic_error( internal::format( "invalid value '", static_cast< std::uint8_t >( v.type() ), "' for tao::json::type" ) );  // LCOV_EXCL_LINE, NOLINT(google-readability-casting)
    }
 
    template< typename Consumer, template< typename... > class Traits >
@@ -191,7 +191,7 @@ namespace tao::json::events
          case type::VALUELESS_BY_EXCEPTION:
             throw std::logic_error( "unable to produce events from valueless-by-exception value" );
       }
-      throw std::logic_error( internal::format( "invalid value '", static_cast< std::uint8_t >( v.type() ), "' for tao::json::type" ) );  // LCOV_EXCL_LINE
+      throw std::logic_error( internal::format( "invalid value '", static_cast< std::uint8_t >( v.type() ), "' for tao::json::type" ) );  // LCOV_EXCL_LINE, NOLINT(google-readability-casting)
    }
 
    template< typename Consumer, template< typename... > class Traits >

include/tao/json/internal/endian_gcc.hpp

@@ -29,12 +29,12 @@ namespace tao::json::internal
    template<>
    struct to_and_from_le< 1 >
    {
-      [[nodiscard]] static std::uint8_t convert( const std::uint8_t n ) noexcept
+      [[nodiscard]] static std::int8_t convert( const std::int8_t n ) noexcept
       {
          return n;
       }
 
-      [[nodiscard]] static std::int8_t convert( const std::int8_t n ) noexcept
+      [[nodiscard]] static std::uint8_t convert( const std::uint8_t n ) noexcept
       {
          return n;
       }
@@ -178,12 +178,12 @@ namespace tao::json::internal
          return n;
       }
 
-      [[nodiscard]] static std::uint64_t convert( const std::uint64_t n ) noexcept
+      [[nodiscard]] static std::int64_t convert( const std::int64_t n ) noexcept
       {
          return static_cast< std::int64_t >( __builtin_bswap64( n ) );
       }
 
-      [[nodiscard]] static std::int64_t convert( const std::int64_t n ) noexcept
+      [[nodiscard]] static std::uint64_t convert( const std::uint64_t n ) noexcept
       {
          return __builtin_bswap64( n );
       }

include/tao/json/msgpack/events/to_stream.hpp

@@ -40,7 +40,7 @@ namespace tao::json::msgpack::events
 
       void boolean( const bool v )
       {
-         os.put( static_cast< char >( 0xc2 ) + static_cast< char >( v ) );
+         os.put( static_cast< char >( v ? 0xc3 : 0xc2 ) );
       }
 
       template< typename Integer >

include/tao/json/msgpack/internal/grammar.hpp

@@ -71,12 +71,12 @@ namespace tao::json::msgpack::internal
       static void parse_unsafe( Input& in, Consumer& consumer )
       {
          const auto b = in.peek_uint8();
-         if( b <= std::uint8_t( format::POSITIVE_MAX ) ) {
+         if( b <= static_cast< std::uint8_t >( format::POSITIVE_MAX ) ) {
             consumer.number( static_cast< std::uint64_t >( b ) );
             in.bump_in_this_line();
             return;
          }
-         if( b >= std::uint8_t( format::NEGATIVE_MIN ) ) {
+         if( b >= static_cast< std::uint8_t >( format::NEGATIVE_MIN ) ) {
             consumer.number( static_cast< std::int64_t >( static_cast< std::int8_t >( b ) ) );
             in.bump_in_this_line();
             return;

include/tao/json/ubjson/events/to_stream.hpp

@@ -85,7 +85,7 @@ namespace tao::json::ubjson::events
          else {
             os.put( 'H' );
             os.put( 'U' );
-            os.put( static_cast< char >( 19 ) + static_cast< char >( v >= 10000000000000000000ULL ) );
+            os.put( static_cast< char >( ( v >= 10000000000000000000ULL ) ? 20 : 19 ) );
             os << v;
          }
       }