Skip to content

Commit f2e8de3

Browse files
committed
Improve test coverage.
1 parent 4d62d67 commit f2e8de3

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

src/test/json/create.cc

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ namespace tao
2020
TEST_ASSERT( ! v.is_string() );
2121
TEST_ASSERT( ! v.is_array() );
2222
TEST_ASSERT( ! v.is_object() );
23+
TEST_ASSERT( ! v.is_number() );
2324

2425
TEST_THROWS( v.get_bool() );
2526
TEST_THROWS( v.get_int64() );
@@ -50,6 +51,7 @@ namespace tao
5051
TEST_ASSERT( ! v.is_string() );
5152
TEST_ASSERT( ! v.is_array() );
5253
TEST_ASSERT( ! v.is_object() );
54+
TEST_ASSERT( ! v.is_number() );
5355

5456
TEST_THROWS( v.get_int64() );
5557
TEST_THROWS( v.get_double() );
@@ -81,6 +83,7 @@ namespace tao
8183
TEST_ASSERT( ! v.is_string() );
8284
TEST_ASSERT( ! v.is_array() );
8385
TEST_ASSERT( ! v.is_object() );
86+
TEST_ASSERT( v.is_number() );
8487

8588
TEST_THROWS( v.get_bool() );
8689
TEST_THROWS( v.get_double() );
@@ -116,6 +119,7 @@ namespace tao
116119
TEST_ASSERT( ! v.is_string() );
117120
TEST_ASSERT( ! v.is_array() );
118121
TEST_ASSERT( ! v.is_object() );
122+
TEST_ASSERT( v.is_number() );
119123

120124
TEST_THROWS( v.get_bool() );
121125
TEST_THROWS( v.get_int64() );
@@ -143,6 +147,7 @@ namespace tao
143147
TEST_ASSERT( v.is_string() );
144148
TEST_ASSERT( ! v.is_array() );
145149
TEST_ASSERT( ! v.is_object() );
150+
TEST_ASSERT( ! v.is_number() );
146151

147152
TEST_THROWS( v.get_bool() );
148153
TEST_THROWS( v.get_int64() );
@@ -174,6 +179,7 @@ namespace tao
174179
TEST_ASSERT( ! v.is_string() );
175180
TEST_ASSERT( v.is_array() );
176181
TEST_ASSERT( ! v.is_object() );
182+
TEST_ASSERT( ! v.is_number() );
177183

178184
TEST_THROWS( v.get_bool() );
179185
TEST_THROWS( v.get_int64() );
@@ -198,6 +204,7 @@ namespace tao
198204
TEST_ASSERT( ! v.is_string() );
199205
TEST_ASSERT( ! v.is_array() );
200206
TEST_ASSERT( v.is_object() );
207+
TEST_ASSERT( ! v.is_number() );
201208

202209
TEST_THROWS( v.get_bool() );
203210
TEST_THROWS( v.get_int64() );
@@ -218,6 +225,7 @@ namespace tao
218225
const value v{ 1, 2, 3, 4 };
219226

220227
TEST_ASSERT( v.is_array() );
228+
TEST_ASSERT( ! v.is_number() );
221229
TEST_ASSERT( v.type() == type::ARRAY );
222230

223231
const std::vector< value > r = { value( 1 ), value( 2 ), value( 3 ), value( 4 ) };

src/test/json/double.cc

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,6 @@ namespace tao
132132

133133
TEST_THROWS( from_string( "1.0e1234567890" ) );
134134
TEST_THROWS( from_string( std::string( 1048577, '1' ) ) );
135-
136135
{
137136
const auto a = from_string( "42.0" ).as_number< double >();
138137
TEST_ASSERT( sizeof( a ) == sizeof( double ) );
@@ -146,6 +145,8 @@ namespace tao
146145
TEST_ASSERT( sizeof( a ) == sizeof( double ) );
147146
TEST_ASSERT( a == 42.0 );
148147
}
148+
TEST_THROWS( value( "foo" ).as_number< double >() );
149+
TEST_THROWS( value( "bar" ).as_number< int >() );
149150
}
150151

151152
} // json

0 commit comments

Comments
 (0)