Skip to content
This repository was archived by the owner on Jan 1, 2024. It is now read-only.

Commit 678d983

Browse files
authored
Update list of dynamic params (#399)
Closed #395 Add some dynamic params: `election_mode`, `election_timeout`, `memtx_max_tuple_size`, `panic_on_wal_error`, `replication`.
1 parent 395161a commit 678d983

File tree

2 files changed

+27
-22
lines changed

2 files changed

+27
-22
lines changed

library/cartridge_get_needs_restart.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,13 +47,13 @@ def read_yaml_file_section(control_console, file_path, section):
4747
def check_conf_updated(new_conf, old_conf, ignore_keys):
4848
# check new conf keys
4949
for key, value in new_conf.items():
50-
if key not in ignore_keys or []:
50+
if key not in (ignore_keys or set()):
5151
if key not in old_conf or old_conf[key] != value:
5252
return True
5353

5454
# check old conf keys
5555
for key, value in old_conf.items():
56-
if key not in ignore_keys or []:
56+
if key not in (ignore_keys or set()):
5757
if key not in new_conf or new_conf[key] != value:
5858
return True
5959

module_utils/helpers.py

Lines changed: 25 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -13,36 +13,41 @@
1313

1414
# parameters of instance configuration that can be changed dynamically
1515
DYNAMIC_BOX_CFG_PARAMS = {
16-
'memtx_memory',
17-
'vinyl_memory',
16+
'checkpoint_count',
17+
'checkpoint_interval',
18+
'checkpoint_wal_threshold',
1819
'custom_proc_title',
20+
'election_mode',
21+
'election_timeout',
22+
'feedback_enabled',
23+
'feedback_host',
24+
'feedback_interval',
25+
'io_collect_interval',
1926
'listen',
27+
'log_format',
28+
'log_level',
29+
'memtx_max_tuple_size',
30+
'memtx_memory',
31+
'net_msg_max',
32+
'panic_on_wal_error',
2033
'read_only',
21-
'sql_cache_size',
22-
'vinyl_timeout',
23-
'worker_pool_threads',
24-
'vinyl_cache',
25-
'checkpoint_interval',
26-
'checkpoint_count',
27-
'checkpoint_wal_threshold',
28-
'snap_io_rate_limit',
29-
'replication_connect_timeout',
34+
'readahead',
35+
'replication',
3036
'replication_connect_quorum',
37+
'replication_connect_timeout',
3138
'replication_skip_conflict',
3239
'replication_sync_lag',
3340
'replication_sync_timeout',
34-
'replication_timeout',
3541
'replication_synchro_quorum',
3642
'replication_synchro_timeout',
37-
'io_collect_interval',
38-
'net_msg_max',
39-
'readahead',
40-
'log_level',
43+
'replication_timeout',
44+
'snap_io_rate_limit',
45+
'sql_cache_size',
4146
'too_long_threshold',
42-
'log_format',
43-
'feedback_enabled',
44-
'feedback_host',
45-
'feedback_interval',
47+
'vinyl_cache',
48+
'vinyl_memory',
49+
'vinyl_timeout',
50+
'worker_pool_threads',
4651
}
4752

4853
MEMORY_SIZE_BOX_CFG_PARAMS = {

0 commit comments

Comments
 (0)