Skip to content
This repository was archived by the owner on Jan 1, 2024. It is now read-only.

Commit f064909

Browse files
authored
Fixes for Ansible 4.0 (#342)
Task 'Set facts that can be set by the user' fell on Ansible 4.0. Now it works. Also added skipped molecule test.
1 parent b950ef9 commit f064909

File tree

3 files changed

+6
-0
lines changed

3 files changed

+6
-0
lines changed

.github/helpers/count_molecule_matrix.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@ def main(event_name, repo_owner, review_state, ref):
4949

5050
if event_name == 'workflow_dispatch' or review_state == 'approved' or ref == 'refs/heads/master':
5151
ce_matrix.append(get_ce_params(molecule_scenario='check_facts'))
52+
ce_matrix.append(get_ce_params(molecule_scenario='cluster_cookie'))
5253
ce_matrix.append(get_ce_params(molecule_scenario='config_upload'))
5354
ce_matrix.append(get_ce_params(molecule_scenario='dead_instances'))
5455
ce_matrix.append(get_ce_params(molecule_scenario='eval'))
@@ -64,6 +65,7 @@ def main(event_name, repo_owner, review_state, ref):
6465

6566
ce_matrix.append(get_ce_params(ansible_version='2.9.0'))
6667
ce_matrix.append(get_ce_params(ansible_version='2.10.0'))
68+
ce_matrix.append(get_ce_params(ansible_version='4.0.0'))
6769

6870
# TODO: Uncomment after fixing the check mode
6971
# ce_matrix.append(get_ce_version(molecule_command='check'))

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ README.md to use the newest tag with new release
1414

1515
- Fail on getting control instance when all unjoined instances haven't
1616
`replicaset_alias` set
17+
- Support of Ansible 4.0
1718

1819
### Added
1920

tasks/prepare.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,9 @@
2323
run_once: true
2424
delegate_to: localhost
2525
become: false
26+
when: >-
27+
cartridge_delivered_package_path or
28+
cartridge_control_instance
2629
2730
- name: 'Collect instance info'
2831
cartridge_get_instance_info:

0 commit comments

Comments
 (0)