Skip to content

Commit 0e33209

Browse files
olegrokTotktonada
authored andcommitted
frontend/validate: remove redundant variable assign
Stack here is used only to provide user with error message. So it makes sence to move stack.ptr assign directly before error will be throwed. benchmark.lua shows a little speedup after such change.
1 parent 31c9fdd commit 0e33209

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

avro_schema/frontend.lua

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -850,12 +850,11 @@ copy_data = function(stack, schema, data, visited)
850850
local fieldmap = get_record_field_map(schema)
851851
-- check if the data contains unknown fields
852852
for k, _ in pairs(data) do
853-
stack.ptr[frame_no] = k
854853
local field = schema.fields[fieldmap[k]]
855854
if not field or field.name ~= k then
855+
stack.ptr[frame_no] = k
856856
error('@Unknown field', 0)
857857
end
858-
stack.ptr[frame_no] = nil
859858
end
860859
-- copy data
861860
for _, field in ipairs(schema.fields) do

0 commit comments

Comments
 (0)