Select with not valid value error handing (#64)

Before this patch we incorrectly created errors objects instead of
errors classes. This led to "attempt to call method 'new'" when
select returned an error. This patch fixes such behaviour and creates error classes.

Closes #61

Author: savolgin

CHANGELOG.md

@@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 ### Fixed
 * Select by primary index name
+* Fix error handling select with invalid type value 
 
 ## [0.2.0] - 2020-10-07
 

crud/select/iterator.lua

@@ -4,8 +4,8 @@ local fiber = require('fiber')
 local dev_checks = require('crud.common.dev_checks')
 local utils = require('crud.common.utils')
 
-local UpdateTuplesError = errors.new('UpdateTuplesError')
-local GetTupleError = errors.new('GetTupleError')
+local UpdateTuplesError = errors.new_class('UpdateTuplesError')
+local GetTupleError = errors.new_class('GetTupleError')
 
 local Heap = require('crud.common.heap')
 

test/integration/select_test.lua

@@ -123,6 +123,23 @@ add('test_non_existent_space', function(g)
     t.assert_str_contains(err.err, "Space non_existent_space doesn't exist")
 end)
 
+add('test_not_valid_value_type', function(g)
+    local conditions = {
+        {'=', 'id', 'not_number'}
+    }
+
+    local obj, err = g.cluster.main_server.net_box:eval([[
+        local crud = require('crud')
+        local conditions = ...
+
+        local result, err = crud.select('customers', conditions)
+        return result, err
+    ]], {conditions})
+
+    t.assert_equals(obj, nil)
+    t.assert_str_contains(err.err, "Supplied key type of part 0 does not match index part type: expected unsigned")
+end)
+
 add('test_select_all', function(g)
     local customers = insert_customers(g, {
         {