Fix tests after fast/safe mode changes

* add access to _bucket space in privillage tests
* fix select_readview_test
* enable double buckets test
* add safe_mode_disable for cartirdge reload test: test_storage
* add safe_mode_disable for test_any_vshard_call_timeout

Author: Satbek

crud/common/call.lua

@@ -125,7 +125,6 @@ local function call_with_retry_and_recovery(vshard_router,
 
     -- This is a partial copy of error handling from vshard.router.router_call_impl()
     -- It is much simpler mostly because bucket_set() can't be accessed from outside vshard.
-    -- may be we cant get this -- todo: check
     if err.class_name == bucket_ref_unref.BucketRefError.name then
         local redirect_replicaset
         if is_single_call and #err.bucket_ref_errs == 1 then

test/integration/cartridge_reload_test.lua

@@ -113,6 +113,11 @@ function g.test_storage()
     t.skip_if(not helpers.is_cartridge_hotreload_supported(),
         "Cartridge roles reload is not supported")
     helpers.skip_old_tarantool_cartridge_hotreload()
+    helpers.call_on_storages(g.cluster, function(server)
+        server.net_box:eval([[
+            require('crud.common.rebalance').safe_mode_disable()
+        ]])
+    end)
 
     g.highload_fiber = fiber.new(highload_loop, 'B')
 

test/integration/double_buckets_test.lua

@@ -57,11 +57,11 @@ end)
 --- Rebalance stalls if we move all buckets at once; use a small subset.
 local test_tuples = {
     {22, box.NULL, 'Alex', 34},
-    -- {92, box.NULL, 'Artur', 29},
-    -- {3, box.NULL, 'Anastasia', 22},
-    -- {5, box.NULL, 'Sergey', 25},
-    -- {9, box.NULL, 'Anna', 30},
-    -- {71, box.NULL, 'Oksana', 29},
+    {92, box.NULL, 'Artur', 29},
+    {3, box.NULL, 'Anastasia', 22},
+    {5, box.NULL, 'Sergey', 25},
+    {9, box.NULL, 'Anna', 30},
+    {71, box.NULL, 'Oksana', 29},
 }
 
 local last_call = fiber.time()
@@ -120,7 +120,6 @@ pgroup_duplicates.test_duplicates = function(g)
         'test implemented only for 3.1 and greater'
     )
     if g.params.backend == "config" then
-        t.xfail('not implemented yet')
         duplicate_operations[g.params.operation](g)
 
         local cfg = g.cluster:cfg()
@@ -246,8 +245,8 @@ pgroup_not_applied.test_not_applied = function(g)
         ),
         'test implemented only for 3.1 and greater'
     )
+    t.skip_if(g.params.operation == 'get' and g.params.safe_mode == false, 'todo: rework get')
     if g.params.backend == "config" then
-        t.xfail('not implemented yet')
         local tuples, tuples_count = {}, 1000
         for i = 1, tuples_count do
             tuples[i] = {i, box.NULL, 'John Fedor', 42}

test/integration/privileges_test.lua

@@ -123,6 +123,9 @@ local function privilegies_test_base_init(g, access_operation_type)
             if access_operation_type and box.space.customers then
                 box.schema.user.grant('testuser1', access_operation_type, 'space', 'customers')
             end
+            if box.space._bucket then
+                box.schema.user.grant('testuser1', 'read', 'space', '_bucket')
+            end
 
             box.session.su(user)
         end

test/integration/select_readview_test.lua

@@ -2353,6 +2353,11 @@ end)
 
 pgroup.test_select_switch_master = function(g)
     helpers.skip_not_cartridge_backend(g.params.backend)
+    helpers.call_on_storages(g.cluster, function(server)
+        server.net_box:eval([[
+            require('crud.common.rebalance').safe_mode_disable()
+        ]])
+    end)
 
     helpers.insert_objects(g, 'customers', {
         {

test/unit/call_test.lua

@@ -242,6 +242,11 @@ pgroup.test_any_vshard_call = function(g)
 end
 
 pgroup.test_any_vshard_call_timeout = function(g)
+    helpers.call_on_storages(g.cluster, function(server)
+        server.net_box:eval([[
+            require('crud.common.rebalance').safe_mode_disable()
+        ]])
+    end)
     local timeout = 0.2
 
     local results, err = g.router:eval([[