Add name parameter and box.error.is function description to box.error.
#5112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
nshy
requested changes
May 14, 2025
Fix comments recieved from SME
nshy
reviewed
May 15, 2025
nshy
approved these changes
May 15, 2025
|
I'm not sure about policies in this particular repo but I'd better merge parts of commit with fixes into appropriate commits. Or you do it before pushing and add commit with changes for the sake of review? |
veod32
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 3.1.0 there has been the
nameparameter,which returns the name of the error used at creation.Fixes #4150