Skip to content

Conversation

@AArdeev
Copy link
Contributor

@AArdeev AArdeev commented Jun 6, 2025

Fixes #5152

@AArdeev AArdeev requested a review from Totktonada June 6, 2025 11:35
@AArdeev AArdeev self-assigned this Jun 6, 2025
@AArdeev AArdeev added the doc_gap label Jun 6, 2025
@AArdeev AArdeev requested a review from Totktonada June 9, 2025 10:36
Comment on lines 99 to 103
.. literalinclude:: /code_snippets/snippets/config/instances.enabled/credentials/revoke_all.yaml
:language: yaml
:start-at: # empty permissions array
:end-at: [ books ]
:dedent:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed


To revoke a previously granted privilege, remove it from the configuration.

For example, here is how to to grant privileges to a space and how to revoke one of the privileges:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: to to.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@@ -0,0 +1,15 @@
# grant privileges
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments ends with a colon, but some don't.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Comment on lines 2 to 4
sampleuser:
password: '123456'
roles: [ writers_space_reader ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to show any password/roles? It seems irrelevent to the idea we're describing.

I guess if we show everything starting from the privileges key, it is easy enough to understand. But at least I would eliminate passwords and roles.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's remove

@AArdeev AArdeev merged commit 6406bbd into latest Jun 9, 2025
1 check passed
@AArdeev AArdeev deleted the AArdeev/gh-5152-revoke-grants-paragraph branch June 9, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a "Revoking grants" paragraph to documentation

3 participants