Skip to content

Conversation

bigbes
Copy link
Collaborator

@bigbes bigbes commented Aug 20, 2025

  • now versions that are supported in gha for testing are 1.23-1.25
  • running golangci-lint and checking code generation diff on latest 1.25 version

* now versions that are supported in gha are 1.23-1.25
* running golangci-lint and checking code generation diff on latest 1.25
  version
@bigbes bigbes requested a review from oleg-jukovec August 20, 2025 18:46
Copy link
Collaborator

@oleg-jukovec oleg-jukovec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the patch!

fail-fast: false
matrix:
golang: ['1.23', 'stable']
golang: ['1.23', '1.24', 'stable']
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to test on minimal supported and maximum version here (1.23 and 'stable'), but up to you.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer running on all version of Go, despite compatibility: runners are free, resources are not ours and tests are completed in parallel :)

@bigbes bigbes merged commit 7a7e26c into master Aug 21, 2025
14 checks passed
@bigbes bigbes deleted the bigbes/tntp-no-golang-update branch August 21, 2025 13:32
@coveralls
Copy link

Coverage Status

coverage: 91.616%. remained the same
when pulling 871cd14 on bigbes/tntp-no-golang-update
into 52b5f36 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants