tests: fix flaky_TestConnectionHandlerOpenUpdateClose

babyTsakhes · oleg-jukovec · commit e3b956cfb90b · 2026-02-03T15:36:53.000+03:00
Increased the time CheckTimeout to 100 milliseconds. The previous timeout leads to too early fail in pool.Connect. Closes #502
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -33,6 +33,9 @@ Versioning](http://semver.org/spec/v2.0.0.html) except to the first release.
 
 ### Fixed
 
+* Fixed the fluctuating behavior of the TestConnectionHandlerOpenUpdateClose
+  test by increasing the waiting time (#502).
+
 ## [v2.4.1] - 2025-10-16
 
 This maintenance release marks the end of active development on the `v2`
diff --git a/pool/connection_pool_test.go b/pool/connection_pool_test.go
@@ -1123,7 +1123,7 @@ func TestConnectionHandlerOpenUpdateClose(t *testing.T) {
 
 	h := &testHandler{}
 	poolOpts := pool.Opts{
-		CheckTimeout:      100 * time.Microsecond,
+		CheckTimeout:      100 * time.Millisecond,
 		ConnectionHandler: h,
 	}
 	connPool, err := pool.ConnectWithOpts(ctx, poolInstances, poolOpts)

Original file line number	Diff line number	Diff line change
`@@ -1123,7 +1123,7 @@ func TestConnectionHandlerOpenUpdateClose(t *testing.T) {`
`1123`	`1123`
`1124`	`1124`	`h := &testHandler{}`
`1125`	`1125`	`poolOpts := pool.Opts{`
`1126`		`- CheckTimeout: 100 * time.Microsecond,`
	`1126`	`+ CheckTimeout: 100 * time.Millisecond,`
`1127`	`1127`	`ConnectionHandler: h,`
`1128`	`1128`	`}`
`1129`	`1129`	`connPool, err := pool.ConnectWithOpts(ctx, poolInstances, poolOpts)`