crud: replace usage of optional types in crud with go-option

Code is formatted.
fixed #492

Author: New year

crud/compile_test.go

@@ -2,34 +2,34 @@
 package crud
 
 import (
-	"github.com/tarantool/go-option"
 	"testing"
+
+	"github.com/tarantool/go-option"
 )
 
-// TestOptionTypesCompilation проверяет что все типы option компилируются правильно
+// TestOptionTypesCompilation verifies that all option types are compiled correctly.
 func TestOptionTypesCompilation(t *testing.T) {
 	// Test BaseOpts
 	baseOpts := BaseOpts{
 		Timeout:      option.SomeFloat64(1.5),
 		VshardRouter: option.SomeString("router"),
 	}
 
-	// Проверяем что Get() работает
+	// Check that Get() is working.
 	if timeout, exists := baseOpts.Timeout.Get(); !exists || timeout != 1.5 {
 		t.Errorf("BaseOpts.Timeout.Get() failed")
 	}
 
-	// Test SimpleOperationOpts
+	// Test SimpleOperationOpts.
 	simpleOpts := SimpleOperationOpts{
 		Timeout:             option.SomeFloat64(2.0),
 		VshardRouter:        option.SomeString("router2"),
 		Fields:              MakeOptAny([]interface{}{"field1", "field2"}),
-		BucketId:            option.SomeUint(456), // Теперь это правильный тип
+		BucketId:            option.SomeUint(456),
 		FetchLatestMetadata: option.SomeBool(true),
 		Noreturn:            option.SomeBool(false),
 	}
 
-	// Проверяем все поля
 	if bucket, exists := simpleOpts.BucketId.Get(); !exists || bucket != 456 {
 		t.Errorf("BucketId.Get() failed: got %v, %v", bucket, exists)
 	}
@@ -40,7 +40,7 @@ func TestOptionTypesCompilation(t *testing.T) {
 		t.Logf("Fields: %v", fields)
 	}
 
-	// Test OperationManyOpts
+	// Test OperationManyOpts.
 	manyOpts := OperationManyOpts{
 		Timeout:     option.SomeFloat64(3.0),
 		StopOnError: option.SomeBool(true),
@@ -51,9 +51,9 @@ func TestOptionTypesCompilation(t *testing.T) {
 	}
 }
 
-// TestMakeOptAny проверяет работу MakeOptAny (замена MakeOptTuple)
+// TestMakeOptAny checks the operation of MakeOptAny (replacing MakeOptTuple).
 func TestMakeOptAny(t *testing.T) {
-	// Test с простыми типами данных
+	// Test with simple data types.
 	testCases := []struct {
 		name     string
 		value    interface{}
@@ -84,7 +84,7 @@ func TestMakeOptAny(t *testing.T) {
 		})
 	}
 
-	// Test со срезом - проверяем без сравнения значений
+	// Test with a slice - we check without comparing the values.
 	t.Run("slice", func(t *testing.T) {
 		sliceValue := []interface{}{"id", "name"}
 		opt := MakeOptAny(sliceValue)
@@ -94,7 +94,7 @@ func TestMakeOptAny(t *testing.T) {
 			t.Errorf("Expected value for slice, but got none")
 		}
 
-		// Проверяем тип и длину вместо прямого сравнения
+		// We check the type and length instead of direct comparison.
 		if valSlice, ok := val.([]interface{}); !ok {
 			t.Errorf("Expected slice type, got %T", val)
 		} else if len(valSlice) != 2 {

crud/options.go

@@ -27,117 +27,6 @@ const (
 	cachedOptName                        = "cached"
 )
 
-// OptUint is an optional uint. Old local optional type.
-/* type OptUint struct {
-	value uint
-	exist bool
-} */
-
-// MakeOptUint creates an optional uint from value.
-/* func MakeOptUint(value uint) OptUint {
-	return OptUint{
-		value: value,
-		exist: true,
-	}
-} */
-
-/* // Get returns the integer value or an error if not present.
-func (opt OptUint) Get() (uint, bool) {
-	return opt.value, opt.exist // Method Get() from go-options is same.
-}
-*/
-/* // OptInt is an optional int.
-type OptInt struct {
-	value int
-	exist bool
-}
-
-// MakeOptInt creates an optional int from value.
-func MakeOptInt(value int) OptInt {
-	return OptInt{
-		value: value,
-		exist: true,
-	}
-}
-
-// Get returns the integer value or an error if not present.
-func (opt OptInt) Get() (int, bool) {
-	return opt.value, opt.exist
-}
-
-// OptFloat64 is an optional float64.
-type OptFloat64 struct {
-	value float64
-	exist bool
-}
-
-// MakeOptFloat64 creates an optional float64 from value.
-func MakeOptFloat64(value float64) OptFloat64 {
-	return OptFloat64{
-		value: value,
-		exist: true,
-	}
-}
-
-// Get returns the float64 value or an error if not present.
-func (opt OptFloat64) Get() (float64, bool) {
-	return opt.value, opt.exist
-}
-
-// OptString is an optional string.
-type OptString struct {
-	value string
-	exist bool
-}
-
-// MakeOptString creates an optional string from value.
-func MakeOptString(value string) OptString {
-	return OptString{
-		value: value,
-		exist: true,
-	}
-}
-
-// Get returns the string value or an error if not present.
-func (opt OptString) Get() (string, bool) {
-	return opt.value, opt.exist
-}
-
-// OptBool is an optional bool.
-type OptBool struct {
-	value bool
-	exist bool
-}
-
-// MakeOptBool creates an optional bool from value.
-func MakeOptBool(value bool) OptBool {
-	return OptBool{
-		value: value,
-		exist: true,
-	}
-}
-
-// Get returns the boolean value or an error if not present.
-func (opt OptBool) Get() (bool, bool) {
-	return opt.value, opt.exist
-} */
-
-// OptTuple is an optional tuple.
-/* type OptTuple struct {
-	tuple interface{}
-}
-
-// MakeOptTuple creates an optional tuple from tuple.
-func MakeOptTuple(tuple interface{}) OptTuple {
-	return OptTuple{tuple}
-}
-
-// Get returns the tuple value or an error if not present.
-func (o *OptTuple) Get() (interface{}, bool) {
-	return o.tuple, o.tuple != nil
-}
-*/
-
 // Defining an alias for Generic[interface{}] to replace OptTuple
 type OptAny = option.Generic[interface{}]