Skip to content

Commit 2610ecf

Browse files
tdg_dashboard: use expirationd module metrics
Since TDG 2.6.0, it uses expirationd module metrics instead of custom TDG 2 expiration metrics [1]. 1. tarantool/tdg2@f6c78cf Closes #164
1 parent 82ccc83 commit 2610ecf

14 files changed

+47
-260
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1515
- Set InfluxDB `measurement` dynamically
1616
- Set InfluxDB `policy` dynamically
1717
- Set datasource dynamically
18+
- Use expirationd module metrics in TDG dashboard
1819

1920
### Fixed
2021
- TDG dashboard latency units (graphql, iproto, rest requests)

dashboard/build/influxdb/tdg_dashboard_raw.libsonnet

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,7 @@ function(
160160
alias=alias,
161161
)
162162
).addPanels(
163-
section.tdg_expirationd(
163+
section.expirationd(
164164
datasource_type=variable.datasource_type.influxdb,
165165
datasource=datasource,
166166
policy=policy,

dashboard/build/prometheus/tdg_dashboard_raw.libsonnet

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ function(
155155
alias=alias,
156156
)
157157
).addPanels(
158-
section.tdg_expirationd(
158+
section.expirationd(
159159
datasource_type=variable.datasource_type.prometheus,
160160
datasource=datasource,
161161
job=job,

dashboard/panels/tdg/expirationd.libsonnet

Lines changed: 0 additions & 173 deletions
This file was deleted.

dashboard/section.libsonnet

Lines changed: 0 additions & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ local slab = import 'dashboard/panels/slab.libsonnet';
1111
local space = import 'dashboard/panels/space.libsonnet';
1212
local vinyl = import 'dashboard/panels/vinyl.libsonnet';
1313

14-
local tdg_expirationd = import 'dashboard/panels/tdg/expirationd.libsonnet';
1514
local tdg_file_connectors = import 'dashboard/panels/tdg/file_connectors.libsonnet';
1615
local tdg_graphql = import 'dashboard/panels/tdg/graphql.libsonnet';
1716
local tdg_iproto = import 'dashboard/panels/tdg/iproto.libsonnet';
@@ -2180,46 +2179,6 @@ local tdg_tuples = import 'dashboard/panels/tdg/tuples.libsonnet';
21802179
),
21812180
],
21822181

2183-
tdg_expirationd(datasource_type, datasource, policy=null, measurement=null, job=null, alias=null):: [
2184-
tdg_expirationd.row,
2185-
2186-
tdg_expirationd.tuples_checked(
2187-
datasource_type=datasource_type,
2188-
datasource=datasource,
2189-
policy=policy,
2190-
measurement=measurement,
2191-
job=job,
2192-
alias=alias,
2193-
),
2194-
2195-
tdg_expirationd.tuples_expired(
2196-
datasource_type=datasource_type,
2197-
datasource=datasource,
2198-
policy=policy,
2199-
measurement=measurement,
2200-
job=job,
2201-
alias=alias,
2202-
),
2203-
2204-
tdg_expirationd.restarts(
2205-
datasource_type=datasource_type,
2206-
datasource=datasource,
2207-
policy=policy,
2208-
measurement=measurement,
2209-
job=job,
2210-
alias=alias,
2211-
),
2212-
2213-
tdg_expirationd.operation_time(
2214-
datasource_type=datasource_type,
2215-
datasource=datasource,
2216-
policy=policy,
2217-
measurement=measurement,
2218-
job=job,
2219-
alias=alias,
2220-
),
2221-
],
2222-
22232182
tdg_tuples(datasource_type, datasource, policy=null, measurement=null, job=null, alias=null):: [
22242183
tdg_tuples.row,
22252184

supported_metrics.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -249,10 +249,10 @@ Based on [tarantool/tdg2 2.6.7](https://github.com/tarantool/tdg2/releases/tag/2
249249
- **tdg_kafka_eos_producer_id**: unsupported ([#134](https://github.com/tarantool/grafana-dashboard/issues/134), decided not to support: doesn't seem useful for visualization)
250250
- **tdg_kafka_eos_producer_epoch**: unsupported ([#134](https://github.com/tarantool/grafana-dashboard/issues/134), decided not to support: doesn't seem useful for visualization)
251251
- **tdg_kafka_eos_epoch_cnt**: unsupported ([#134](https://github.com/tarantool/grafana-dashboard/issues/134), decided not to support: doesn't seem useful for visualization)
252-
- [x] **tdg_expiration_checked_count**: see *TDG expirationd statistics/Tuples checked* panel ([#134](https://github.com/tarantool/grafana-dashboard/issues/134), [#164](https://github.com/tarantool/grafana-dashboard/issues/164))
253-
- [x] **tdg_expiration_expired_count**: see *TDG expirationd statistics/Tuples expired* panel ([#134](https://github.com/tarantool/grafana-dashboard/issues/134), [#164](https://github.com/tarantool/grafana-dashboard/issues/164))
254-
- [x] **tdg_expiration_restarts**: see *TDG expirationd statistics/Restart count* panel ([#134](https://github.com/tarantool/grafana-dashboard/issues/134), [#164](https://github.com/tarantool/grafana-dashboard/issues/164))
255-
- [x] **tdg_expiration_working_time**: see *TDG expirationd statistics/Operation time* panel ([#134](https://github.com/tarantool/grafana-dashboard/issues/134), [#164](https://github.com/tarantool/grafana-dashboard/issues/164))
252+
- **tdg_expiration_checked_count**: unsupported ([#164](https://github.com/tarantool/grafana-dashboard/issues/164), deprecated, replaced with **expirationd_checked_count**)
253+
- **tdg_expiration_expired_count**: unsupported ([#164](https://github.com/tarantool/grafana-dashboard/issues/164), deprecated, replaced with **expirationd_expired_count**)
254+
- **tdg_expiration_restarts**: unsupported ([#164](https://github.com/tarantool/grafana-dashboard/issues/164), deprecated, replaced with **expirationd_restarts**)
255+
- **tdg_expiration_working_time**: unsupported ([#164](https://github.com/tarantool/grafana-dashboard/issues/164), deprecated, replaced with **expirationd_working_time**)
256256
- [x] **tnt_cpu_thread**: see *Tarantool CPU statistics/Thread system time*, *Tarantool CPU statistics/Thread user time* panels ([#134](https://github.com/tarantool/grafana-dashboard/issues/134))
257257
- [x] **tdg_scanned_tuples_count**, **tdg_scanned_tuples_sum**: see *TDG tuples statistics/Tuples scanned (average)* panels ([#134](https://github.com/tarantool/grafana-dashboard/issues/134))
258258
- **tdg_scanned_tuples_le**: unsupported ([#134](https://github.com/tarantool/grafana-dashboard/issues/134), decided not to support: **tdg_scanned_tuples_count**, **tdg_scanned_tuples_sum** should be enough)

tests/InfluxDB/dashboard_tdg_compiled.json

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23189,7 +23189,7 @@
2318923189
{
2319023190
"key": "metric_name",
2319123191
"operator": "=",
23192-
"value": "tdg_expiration_checked_count"
23192+
"value": "expirationd_checked_count"
2319323193
},
2319423194
{
2319523195
"condition": "AND",
@@ -23338,7 +23338,7 @@
2333823338
{
2333923339
"key": "metric_name",
2334023340
"operator": "=",
23341-
"value": "tdg_expiration_expired_count"
23341+
"value": "expirationd_expired_count"
2334223342
},
2334323343
{
2334423344
"condition": "AND",
@@ -23481,7 +23481,7 @@
2348123481
{
2348223482
"key": "metric_name",
2348323483
"operator": "=",
23484-
"value": "tdg_expiration_restarts"
23484+
"value": "expirationd_restarts"
2348523485
},
2348623486
{
2348723487
"condition": "AND",
@@ -23624,7 +23624,7 @@
2362423624
{
2362523625
"key": "metric_name",
2362623626
"operator": "=",
23627-
"value": "tdg_expiration_working_time"
23627+
"value": "expirationd_working_time"
2362823628
},
2362923629
{
2363023630
"condition": "AND",
@@ -23678,7 +23678,7 @@
2367823678
"repeatIteration": null,
2367923679
"repeatRowId": null,
2368023680
"showTitle": true,
23681-
"title": "TDG expirationd statistics",
23681+
"title": "expirationd module statistics",
2368223682
"titleSize": "h6",
2368323683
"type": "row"
2368423684
},

tests/InfluxDB/dashboard_tdg_static_compiled.json

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23189,7 +23189,7 @@
2318923189
{
2319023190
"key": "metric_name",
2319123191
"operator": "=",
23192-
"value": "tdg_expiration_checked_count"
23192+
"value": "expirationd_checked_count"
2319323193
},
2319423194
{
2319523195
"condition": "AND",
@@ -23338,7 +23338,7 @@
2333823338
{
2333923339
"key": "metric_name",
2334023340
"operator": "=",
23341-
"value": "tdg_expiration_expired_count"
23341+
"value": "expirationd_expired_count"
2334223342
},
2334323343
{
2334423344
"condition": "AND",
@@ -23481,7 +23481,7 @@
2348123481
{
2348223482
"key": "metric_name",
2348323483
"operator": "=",
23484-
"value": "tdg_expiration_restarts"
23484+
"value": "expirationd_restarts"
2348523485
},
2348623486
{
2348723487
"condition": "AND",
@@ -23624,7 +23624,7 @@
2362423624
{
2362523625
"key": "metric_name",
2362623626
"operator": "=",
23627-
"value": "tdg_expiration_working_time"
23627+
"value": "expirationd_working_time"
2362823628
},
2362923629
{
2363023630
"condition": "AND",
@@ -23678,7 +23678,7 @@
2367823678
"repeatIteration": null,
2367923679
"repeatRowId": null,
2368023680
"showTitle": true,
23681-
"title": "TDG expirationd statistics",
23681+
"title": "expirationd module statistics",
2368223682
"titleSize": "h6",
2368323683
"type": "row"
2368423684
},

0 commit comments

Comments
 (0)