Skip to content

Commit cb30dba

Browse files
DifferentialOrangeDifferentialOrange
committed
tdg_dashboard: fix Kafka partitions metrics
Fix metrics name for "TDG Kafka topics statistics" panels: - "Partition messages sent" (tdg_kafka_topic_partitions_txmsgs), - "Partition message bytes sent" (tdg_kafka_topic_partitions_txbytes), - "Partition messages consumed" (tdg_kafka_topic_partitions_rxmsgs), - "Partition message bytes consumed" (tdg_kafka_topic_partitions_rxbytes), - "Partition messages dropped" (tdg_kafka_topic_partitions_rx_ver_drops), - "Partition messages in flight" (tdg_kafka_topic_partitions_msgs_inflight). Closes #155
1 parent 8da89fd commit cb30dba

File tree

4 files changed

+20
-18
lines changed

4 files changed

+20
-18
lines changed

‎CHANGELOG.md‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
88

99
## Fixed
1010
- TDG dashboard file connectors processed panel name changed to "Total files processed"
11+
- Set valid metrics name to TDG dashboard Kafka partitions panels
12+
1113

1214
## [1.2.0] - 2022-06-08
1315
Grafana revisions: [InfluxDB revision 12](https://grafana.com/api/dashboards/12567/revisions/12/download), [Prometheus revision 12](https://grafana.com/api/dashboards/13054/revisions/12/download), [InfluxDB TDG revision 1](https://grafana.com/api/dashboards/16405/revisions/1/download), [Prometheus TDG revision 1](https://grafana.com/api/dashboards/16406/revisions/1/download).

‎dashboard/panels/tdg/kafka/topics.libsonnet‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -368,7 +368,7 @@ local prometheus = grafana.prometheus;
368368
panel_width=6,
369369
).addTarget(partitions_rps_target(
370370
datasource,
371-
'tdg_kafka_partition_txmsgs',
371+
'tdg_kafka_topic_partitions_txmsgs',
372372
job,
373373
rate_time_range,
374374
policy,
@@ -395,7 +395,7 @@ local prometheus = grafana.prometheus;
395395
panel_width=6,
396396
).addTarget(partitions_rps_target(
397397
datasource,
398-
'tdg_kafka_partition_txbytes',
398+
'tdg_kafka_topic_partitions_txbytes',
399399
job,
400400
rate_time_range,
401401
policy,
@@ -422,7 +422,7 @@ local prometheus = grafana.prometheus;
422422
panel_width=6,
423423
).addTarget(partitions_rps_target(
424424
datasource,
425-
'tdg_kafka_partition_rxmsgs',
425+
'tdg_kafka_topic_partitions_rxmsgs',
426426
job,
427427
rate_time_range,
428428
policy,
@@ -450,7 +450,7 @@ local prometheus = grafana.prometheus;
450450
panel_width=6,
451451
).addTarget(partitions_rps_target(
452452
datasource,
453-
'tdg_kafka_partition_rxbytes',
453+
'tdg_kafka_topic_partitions_rxbytes',
454454
job,
455455
rate_time_range,
456456
policy,
@@ -476,7 +476,7 @@ local prometheus = grafana.prometheus;
476476
panel_width=12,
477477
).addTarget(partitions_rps_target(
478478
datasource,
479-
'tdg_kafka_partition_rx_ver_drops',
479+
'tdg_kafka_topic_partitions_rx_ver_drops',
480480
job,
481481
rate_time_range,
482482
policy,
@@ -501,7 +501,7 @@ local prometheus = grafana.prometheus;
501501
panel_width=12,
502502
).addTarget(partitions_target(
503503
datasource,
504-
'tdg_kafka_partition_msgs_inflight',
504+
'tdg_kafka_topic_partitions_msgs_inflight',
505505
job,
506506
policy,
507507
measurement,

‎tests/InfluxDB/dashboard_tdg_compiled.json‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19980,7 +19980,7 @@
1998019980
{
1998119981
"key": "metric_name",
1998219982
"operator": "=",
19983-
"value": "tdg_kafka_partition_txmsgs"
19983+
"value": "tdg_kafka_topic_partitions_txmsgs"
1998419984
}
1998519985
]
1998619986
}
@@ -20147,7 +20147,7 @@
2014720147
{
2014820148
"key": "metric_name",
2014920149
"operator": "=",
20150-
"value": "tdg_kafka_partition_txbytes"
20150+
"value": "tdg_kafka_topic_partitions_txbytes"
2015120151
}
2015220152
]
2015320153
}
@@ -20314,7 +20314,7 @@
2031420314
{
2031520315
"key": "metric_name",
2031620316
"operator": "=",
20317-
"value": "tdg_kafka_partition_rxmsgs"
20317+
"value": "tdg_kafka_topic_partitions_rxmsgs"
2031820318
}
2031920319
]
2032020320
}
@@ -20481,7 +20481,7 @@
2048120481
{
2048220482
"key": "metric_name",
2048320483
"operator": "=",
20484-
"value": "tdg_kafka_partition_rxbytes"
20484+
"value": "tdg_kafka_topic_partitions_rxbytes"
2048520485
}
2048620486
]
2048720487
}
@@ -20648,7 +20648,7 @@
2064820648
{
2064920649
"key": "metric_name",
2065020650
"operator": "=",
20651-
"value": "tdg_kafka_partition_rx_ver_drops"
20651+
"value": "tdg_kafka_topic_partitions_rx_ver_drops"
2065220652
}
2065320653
]
2065420654
}
@@ -20809,7 +20809,7 @@
2080920809
{
2081020810
"key": "metric_name",
2081120811
"operator": "=",
20812-
"value": "tdg_kafka_partition_msgs_inflight"
20812+
"value": "tdg_kafka_topic_partitions_msgs_inflight"
2081320813
}
2081420814
]
2081520815
}

‎tests/Prometheus/dashboard_tdg_compiled.json‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13044,7 +13044,7 @@
1304413044
"steppedLine": false,
1304513045
"targets": [
1304613046
{
13047-
"expr": "rate(tdg_kafka_partition_txmsgs{job=~\"$job\"}[$rate_time_range])",
13047+
"expr": "rate(tdg_kafka_topic_partitions_txmsgs{job=~\"$job\"}[$rate_time_range])",
1304813048
"format": "time_series",
1304913049
"intervalFactor": 2,
1305013050
"legendFormat": "{{name}} ({{topic}}, {{partition}}) — {{alias}} ({{type}}, {{connector_name}})",
@@ -13134,7 +13134,7 @@
1313413134
"steppedLine": false,
1313513135
"targets": [
1313613136
{
13137-
"expr": "rate(tdg_kafka_partition_txbytes{job=~\"$job\"}[$rate_time_range])",
13137+
"expr": "rate(tdg_kafka_topic_partitions_txbytes{job=~\"$job\"}[$rate_time_range])",
1313813138
"format": "time_series",
1313913139
"intervalFactor": 2,
1314013140
"legendFormat": "{{name}} ({{topic}}, {{partition}}) — {{alias}} ({{type}}, {{connector_name}})",
@@ -13224,7 +13224,7 @@
1322413224
"steppedLine": false,
1322513225
"targets": [
1322613226
{
13227-
"expr": "rate(tdg_kafka_partition_rxmsgs{job=~\"$job\"}[$rate_time_range])",
13227+
"expr": "rate(tdg_kafka_topic_partitions_rxmsgs{job=~\"$job\"}[$rate_time_range])",
1322813228
"format": "time_series",
1322913229
"intervalFactor": 2,
1323013230
"legendFormat": "{{name}} ({{topic}}, {{partition}}) — {{alias}} ({{type}}, {{connector_name}})",
@@ -13314,7 +13314,7 @@
1331413314
"steppedLine": false,
1331513315
"targets": [
1331613316
{
13317-
"expr": "rate(tdg_kafka_partition_rxbytes{job=~\"$job\"}[$rate_time_range])",
13317+
"expr": "rate(tdg_kafka_topic_partitions_rxbytes{job=~\"$job\"}[$rate_time_range])",
1331813318
"format": "time_series",
1331913319
"intervalFactor": 2,
1332013320
"legendFormat": "{{name}} ({{topic}}, {{partition}}) — {{alias}} ({{type}}, {{connector_name}})",
@@ -13404,7 +13404,7 @@
1340413404
"steppedLine": false,
1340513405
"targets": [
1340613406
{
13407-
"expr": "rate(tdg_kafka_partition_rx_ver_drops{job=~\"$job\"}[$rate_time_range])",
13407+
"expr": "rate(tdg_kafka_topic_partitions_rx_ver_drops{job=~\"$job\"}[$rate_time_range])",
1340813408
"format": "time_series",
1340913409
"intervalFactor": 2,
1341013410
"legendFormat": "{{name}} ({{topic}}, {{partition}}) — {{alias}} ({{type}}, {{connector_name}})",
@@ -13494,7 +13494,7 @@
1349413494
"steppedLine": false,
1349513495
"targets": [
1349613496
{
13497-
"expr": "tdg_kafka_partition_msgs_inflight{job=~\"$job\"}",
13497+
"expr": "tdg_kafka_topic_partitions_msgs_inflight{job=~\"$job\"}",
1349813498
"format": "time_series",
1349913499
"intervalFactor": 2,
1350013500
"legendFormat": "{{name}} ({{topic}}, {{partition}}) — {{alias}} ({{type}}, {{connector_name}})",

0 commit comments

Comments
 (0)