Commit a64c6e0
committed
test: wait until server is ready
Current `wait_until_started` method wait till `box.info.status` is
"running" and start sending requests. Such approach is wrong: status
"running" [1] does not guarantees that instance is available for writing
(like creating new users) [2]. It results in flaky test results (for
example, see 4 restarts in [3]).
This patch fixes the issue. After this patch, it is guaranteed that
after `wait_until_ready` call instance had finished to run its
initialization script, including box.cfg, and available for writing data
if it is expected to be able to.
Windows instances use a separate lock mechanism, so this patch is not
related to Windows instances.
1. https://github.com/tarantool/tarantool/blob/983a7ec215d46b6d02935d1baa8bbe07fc371795/src/box/box.cc#L5425-L5426
2. https://github.com/tarantool/tarantool/blob/983a7ec215d46b6d02935d1baa8bbe07fc371795/src/box/box.cc#L5454
3. https://github.com/tarantool/tarantool/actions/runs/57598026201 parent 21f77a6 commit a64c6e0
3 files changed
+12
-13
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
| 22 | + | |
| 23 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
91 | 91 | | |
92 | 92 | | |
93 | 93 | | |
| 94 | + | |
| 95 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
302 | 302 | | |
303 | 303 | | |
304 | 304 | | |
305 | | - | |
| 305 | + | |
306 | 306 | | |
307 | | - | |
| 307 | + | |
308 | 308 | | |
309 | 309 | | |
310 | 310 | | |
311 | | - | |
| 311 | + | |
312 | 312 | | |
313 | 313 | | |
314 | 314 | | |
315 | 315 | | |
316 | 316 | | |
317 | | - | |
318 | | - | |
319 | | - | |
320 | | - | |
321 | | - | |
322 | | - | |
323 | | - | |
324 | | - | |
325 | | - | |
| 317 | + | |
| 318 | + | |
| 319 | + | |
| 320 | + | |
326 | 321 | | |
327 | 322 | | |
328 | 323 | | |
| |||
352 | 347 | | |
353 | 348 | | |
354 | 349 | | |
355 | | - | |
| 350 | + | |
356 | 351 | | |
357 | 352 | | |
358 | 353 | | |
| |||
0 commit comments