test: drop decodeUserTuple helper

The helper is not used since it is trivial to decode data with new
decoder, so let's drop it.

Along the way, alias Buf_t is moved from TupleReader.hpp since it has
nothing in common with tuple definition. Also, the header is renamed to
UserTuple.hpp since it contains only tuple definition now. And, while we
are here, headers in Client tests and UserTuple.hpp are sorted, linter
warning are fixed.

Author: drewdzzz

test/ClientPerfTest.cpp

@@ -29,9 +29,9 @@
  * SUCH DAMAGE.
  */
 #include "Utils/Helpers.hpp"
-#include "Utils/TupleReader.hpp"
-#include "Utils/System.hpp"
 #include "Utils/PerfTimer.hpp"
+#include "Utils/System.hpp"
+#include "Utils/UserTuple.hpp"
 
 #include "../src/Client/Connector.hpp"
 #include "../src/Client/LibevNetProvider.hpp"
@@ -54,6 +54,8 @@ constexpr size_t NUM_TEST = 500;
 constexpr size_t TOTAL_REQ = NUM_REQ * NUM_TEST;
 constexpr size_t NUM_CONN = 1;
 
+using Buf_t = tnt::Buffer<16 * 1024>;
+
 struct RequestResult {
 	double rps;
 	size_t server_rps;

test/ClientTest.cpp

@@ -29,8 +29,8 @@
  * SUCH DAMAGE.
  */
 #include "Utils/Helpers.hpp"
-#include "Utils/TupleReader.hpp"
 #include "Utils/System.hpp"
+#include "Utils/UserTuple.hpp"
 
 #include "../src/Client/LibevNetProvider.hpp"
 #include "../src/Client/Connector.hpp"
@@ -41,6 +41,8 @@ int dummy_server_port = 3302;
 const char *unixsocket = "./tnt.sock";
 int WAIT_TIMEOUT = 1000; //milliseconds
 
+using Buf_t = tnt::Buffer<16 * 1024>;
+
 #ifdef TNTCXX_ENABLE_SSL
 constexpr bool enable_ssl = true;
 constexpr StreamTransport transport = STREAM_SSL;

test/Utils/TupleReader.hpp test/Utils/UserTuple.hpptest/Utils/TupleReader.hpp renamed to test/Utils/UserTuple.hpp

@@ -30,9 +30,8 @@
  * SUCH DAMAGE.
  */
 #include "../src/Buffer/Buffer.hpp"
-#include "../src/mpp/mpp.hpp"
-#include "../src/mpp/Dec.hpp"
 #include "../src/Client/ResponseDecoder.hpp"
+#include "../src/mpp/mpp.hpp"
 
 /** Corresponds to data stored in _space[512]. */
 struct UserTuple {
@@ -46,24 +45,11 @@ struct UserTuple {
 		&UserTuple::field4);
 };
 
-std::ostream&
-operator<<(std::ostream& strm, const UserTuple &t)
+std::ostream &
+operator<<(std::ostream &strm, const UserTuple &t)
 {
 	return strm << "Tuple: field1=" << t.field1 << " field2=" << t.field2 <<
 		    " field3=" << t.field3 <<
 		    " field4.first=" << t.field4.first <<
 		    " field4.second=" << t.field4.second;
 }
-
-using Buf_t = tnt::Buffer<16 * 1024>;
-
-template <class BUFFER>
-std::vector<UserTuple>
-decodeUserTuple(Data<BUFFER> &data)
-{
-	std::vector<UserTuple> result;
-	bool ok = data.decode(result);
-	if (!ok)
-		return std::vector<UserTuple>();
-	return result;
-}