build: add thread sanitizer

We have a cmake option to build Tntcxx with sanitizers. Currently, only
memory and UB sanitizers are used - let's populate the list with thread
sanitizer since we have a test for a multithreaded scenario.

Author: drewdzzz

.github/actions/build-tntcxx/action.yml

@@ -6,7 +6,7 @@ inputs:
     required: true
   enable-sanitizers:
     description: 'Corresponds to TNTCXX_ENABLE_SANITIZERS option of CMake'
-    default: 'false'
+    default: ''
   cxx-standard:
     description: 'Corresponds to CMAKE_CXX_STANDARD option of CMake'
   cxx-compiler:

.github/workflows/reusable-testing.yml

@@ -22,8 +22,8 @@ on:
         default: false
         type: boolean
       enable-sanitizers:
-        default: false
-        type: boolean
+        default: ''
+        type: string
       build-only:
         default: false
         type: boolean

.github/workflows/testing.yml

@@ -100,10 +100,13 @@ jobs:
         exclude:
           - runs-on: macos-14
             compiler: {c: gcc, cxx: g++}
-    name: sanitizers (${{ matrix.runs-on }}, ${{ matrix.build-type }}, ${{ matrix.compiler.c }})
+        sanitizer:
+          - thread
+          - address
+    name: sanitizers (${{ matrix.sanitizer }}, ${{ matrix.runs-on }}, ${{ matrix.build-type }}, ${{ matrix.compiler.c }})
     with:
       runs-on: ${{ matrix.runs-on }}
       build-type: ${{ matrix.build-type }}
       c-compiler: ${{ matrix.compiler.c }}
       cxx-compiler: ${{ matrix.compiler.cxx }}
-      enable-sanitizers: true
+      enable-sanitizers: ${{ matrix.sanitizer }}

CMakeLists.txt

@@ -91,10 +91,12 @@ IF (TNTCXX_BUILD_TESTING)
 ENDIF()
 
 OPTION(TNTCXX_ENABLE_SANITIZERS
-    "If ON, tntcxx will be instrumented with sanitizers."
+    "If passed, tntcxx will be instrumented with sanitizers. Possible values: \"NONE\", \"ADDRESS\", \"THREAD\""
     OFF)
 
-IF (TNTCXX_ENABLE_SANITIZERS)
+IF (NOT TNTCXX_ENABLE_SANITIZERS)
+    # Santiizers are disabled - do nothing.
+ELSEIF (TNTCXX_ENABLE_SANITIZERS STREQUAL "ARRDESS")
     SET(SANITIZER_FLAGS "-fsanitize=address")
     # FIXME(gh-62)
     IF (NOT CMAKE_CXX_COMPILER_ID STREQUAL "AppleClang")
@@ -114,6 +116,12 @@ IF (TNTCXX_ENABLE_SANITIZERS)
     # for details).
     ADD_COMPILE_OPTIONS(${SANITIZER_FLAGS})
     ADD_LINK_OPTIONS(${SANITIZER_FLAGS})
+ELSEIF (TNTCXX_ENABLE_SANITIZERS STREQUAL "THREAD")
+    SET(SANITIZER_FLAGS "-fsanitize=thread")
+    ADD_COMPILE_OPTIONS(${SANITIZER_FLAGS})
+    ADD_LINK_OPTIONS(${SANITIZER_FLAGS})
+ELSE ()
+    MESSAGE(FATAL_ERROR "Unknown TNTCXX_ENABLED_SANITIZERS value")
 ENDIF()
 
 # Common function for building tests.