ci: fix static check errors

Closes TNTP-6083

Author: elhimov

.cspell.yaml

@@ -30,3 +30,9 @@ ignoreRegExpList:
   - ^\s+(\w+\s+)?"github.com/.*" # Ignore Go import paths.
   - -D[A-Z\d_]+ # Ignore CMake flags "-DFLAG_NAME".
   - \d+-g[a-f\d]{4,} # Ignore git commit hashes in version string.
+
+ignorePaths:
+  - magefile.go
+  - /test/**
+  - "*-gdb.py"
+  - "*_test.go"

.cspell_project-words.txt

@@ -4,15 +4,24 @@
 +s
 addfinalizer
 aeon*
+anyhost
+anykey
+anyname
 autoexpel
 bootstrapper
+byted
 ccluster
+cconfig
 clientv3
 clustercmd
+cmdconfig
+cmdcontext
+cmps
 commentf
 configcartridgecustom
 connpool
 containsf
+coredumps
 debugf
 demoter
 disbalance
@@ -24,52 +33,91 @@ etcd*
 etcdserver
 evaler
 falsef
+filemodes
 finalizer*
 flightrec
+framelink
+frametypes
 getfixturevalue
 golangci
+iconfig
 incdir
 infof
+iproto
+jsonmessage
 leaderuuid
 libcluster
+libconnect
+linecomment
 luabody
 luajit
 luakit
 luarocks
+magefile
+MAKEFLAGS
 mapstructure
 memtx
+multireturn
 mvcc
 mvccpb
+myapp
 nilf
 nodeps
 nogc
 nolint
 notarantool
+oldfd
+outputformat
+packignore
+payloadsize
+pflag
+pkgs
+postinst
+preinst
 promptui
 protoc
+pseudographics
 rebootstrap
+regexputil
 replicaset*
+rescan
 rockspec*
 rpmdeb
+rundir
+socketpath
+sourcedir
 specialchars
 sslcafile
+sslcertfile
 sslciphers
+sslkeyfile
 stateboard
+stdcopy
+submatch
 svacer
+sysdetect
+tagset
 tarantool*
+testfull
+tinstance
 tlsdialer
+tmpfiles
 tmpl
 tnt+
 tntp
 trimprefix
 truef
+ttable
+ttlog
+typestr
 unknowncentralized
 unknownnonetarantooletcd
 unknownnosinglemulti
 unknownoffmanualeventualelectionstatefulsupervised
 unknownoffvotercandidatemanual
 unknownreadrw
 unknownuninitializedbootstrapped
+vclock
 vshard
 vylog
 warnf

cli/aeon/decode.go

@@ -15,6 +15,7 @@ import (
 //
 // Copy from https://github.com/tarantool/aeon/blob/master/aeon/grpc/server/pb/decode.go
 func decodeValue(val *pb.Value) (any, error) {
+	// spell-checker:ignore Varbinary
 	switch casted := val.Kind.(type) {
 	case *pb.Value_UnsignedValue:
 		return val.GetUnsignedValue(), nil

cli/replicaset/cconfig.go

@@ -219,19 +219,19 @@ func (c *CConfigApplication) Expel(ctx ExpelCtx) error {
 	}
 
 	var instances []running.InstanceCtx
-	var unfound []string
+	var unavailable []string
 	for _, inst := range targetReplicaset.Instances {
 		if !inst.InstanceCtxFound {
 			if inst.Alias != ctx.InstName {
 				// The target instance could be offline.
-				unfound = append(unfound, inst.Alias)
+				unavailable = append(unavailable, inst.Alias)
 			}
 		} else {
 			instances = append(instances, inst.InstanceCtx)
 		}
 	}
-	if len(unfound) > 0 {
-		msg := fmt.Sprintf("could not connect to: %s", strings.Join(unfound, ","))
+	if len(unavailable) > 0 {
+		msg := fmt.Sprintf("could not connect to: %s", strings.Join(unavailable, ","))
 		if !ctx.Force {
 			return fmt.Errorf(
 				"all other instances in the target replicaset should be online, %s", msg)
@@ -367,16 +367,16 @@ func (c *CConfigApplication) Promote(ctx PromoteCtx) error {
 	}
 
 	var instances []running.InstanceCtx
-	var unfound []string
+	var unavailable []string
 	for _, inst := range targetReplicaset.Instances {
 		if !inst.InstanceCtxFound {
-			unfound = append(unfound, inst.Alias)
+			unavailable = append(unavailable, inst.Alias)
 		} else {
 			instances = append(instances, inst.InstanceCtx)
 		}
 	}
-	if len(unfound) > 0 {
-		msg := fmt.Sprintf("could not connect to: %s", strings.Join(unfound, ","))
+	if len(unavailable) > 0 {
+		msg := fmt.Sprintf("could not connect to: %s", strings.Join(unavailable, ","))
 		if !ctx.Force {
 			return fmt.Errorf("all instances in the target replicaset should be online, %s", msg)
 		}
@@ -406,16 +406,16 @@ func (c *CConfigApplication) Demote(ctx DemoteCtx) error {
 	}
 
 	var instances []running.InstanceCtx
-	var unfound []string
+	var unavailable []string
 	for _, inst := range targetReplicaset.Instances {
 		if !inst.InstanceCtxFound {
-			unfound = append(unfound, inst.Alias)
+			unavailable = append(unavailable, inst.Alias)
 		} else {
 			instances = append(instances, inst.InstanceCtx)
 		}
 	}
-	if len(unfound) > 0 {
-		msg := fmt.Sprintf("could not connect to: %s", strings.Join(unfound, ","))
+	if len(unavailable) > 0 {
+		msg := fmt.Sprintf("could not connect to: %s", strings.Join(unavailable, ","))
 		if !ctx.Force {
 			return fmt.Errorf("all instances in the target replicaset should be online, %s", msg)
 		}
@@ -486,8 +486,8 @@ func (c *CConfigApplication) RolesChange(ctx RolesChangeCtx,
 	}
 
 	var (
-		instances []running.InstanceCtx
-		unfound   []string
+		instances   []running.InstanceCtx
+		unavailable []string
 	)
 
 	if ctx.InstName != "" {
@@ -501,7 +501,7 @@ func (c *CConfigApplication) RolesChange(ctx RolesChangeCtx,
 		}
 		for _, inst := range targetReplicaset.Instances {
 			if !inst.InstanceCtxFound {
-				unfound = append(unfound, inst.Alias)
+				unavailable = append(unavailable, inst.Alias)
 				continue
 			}
 			instances = append(instances, inst.InstanceCtx)
@@ -510,15 +510,15 @@ func (c *CConfigApplication) RolesChange(ctx RolesChangeCtx,
 		for _, r := range c.replicasets.Replicasets {
 			for _, i := range r.Instances {
 				if !i.InstanceCtxFound {
-					unfound = append(unfound, i.Alias)
+					unavailable = append(unavailable, i.Alias)
 					continue
 				}
 				instances = append(instances, i.InstanceCtx)
 			}
 		}
 	}
-	if len(unfound) > 0 {
-		msg := "could not connect to: " + strings.Join(unfound, ",")
+	if len(unavailable) > 0 {
+		msg := "could not connect to: " + strings.Join(unavailable, ",")
 		if !ctx.Force {
 			return fmt.Errorf("all instances in the target replicaset should be online, %s", msg)
 		}

cli/replicaset/cmd/demote.go

@@ -24,7 +24,7 @@ type DemoteCtx struct {
 	Conn connector.Connector
 	// RunningCtx is an application running context.
 	RunningCtx running.RunningCtx
-	// Force true if unfound instances can be skipped.
+	// Force true if unavailable instances can be skipped.
 	Force bool
 	// Timeout describes a timeout in seconds.
 	// We keep int as it can be passed to the target instance.

cli/replicaset/cmd/expel.go

@@ -23,7 +23,7 @@ type ExpelCtx struct {
 	Orchestrator replicaset.Orchestrator
 	// RunningCtx is an application running context.
 	RunningCtx running.RunningCtx
-	// Force true if unfound instances can be skipped.
+	// Force true if unavailable instances can be skipped.
 	Force bool
 	// Timeout describes a timeout in seconds.
 	// We keep int as it can be passed to the target instance.

cli/replicaset/cmd/promote.go

@@ -27,7 +27,7 @@ type PromoteCtx struct {
 	Conn connector.Connector
 	// RunningCtx is an application running context.
 	RunningCtx running.RunningCtx
-	// Force true if unfound instances can be skipped.
+	// Force true if unavailable instances can be skipped.
 	Force bool
 	// Timeout describes a timeout in seconds.
 	// We keep int as it can be passed to the target instance.

cli/replicaset/cmd/roles.go

@@ -35,7 +35,7 @@ type RolesChangeCtx struct {
 	Conn connector.Connector
 	// RunningCtx is an application running context.
 	RunningCtx running.RunningCtx
-	// Force is true if unfound instances can be skipped.
+	// Force is true if unavailable instances can be skipped.
 	Force bool
 	// Timeout describes a timeout in seconds.
 	// We keep int as it can be passed to the target instance.

lib/cluster/etcd.go

@@ -747,11 +747,11 @@ func (publisher EtcdKeyDataPublisher) Publish(revision int64, data []byte) error
 			clientv3.OpPut(getSignKey(publisher.prefix, publisher.key), string(sign)))
 	}
 
-	tresp, err := txn.Then(putOps...).Commit()
+	tResp, err := txn.Then(putOps...).Commit()
 	if err != nil {
 		return fmt.Errorf("failed to put data into etcd: %w", err)
 	}
-	if !tresp.Succeeded {
+	if !tResp.Succeeded {
 		return fmt.Errorf("failed to put data into etcd: wrong revision")
 	}
 

magefile.publish.go

@@ -92,16 +92,16 @@ func PublishRWS() error {
 	for _, targetDistro := range targetDistros {
 		fmt.Printf("Publish package for %s/%s...\n", targetDistro.OS, targetDistro.Dist)
 
-		patterns, perr := getPatterns(targetDistro)
-		if perr != nil {
+		patterns, err := getPatterns(targetDistro)
+		if err != nil {
 			return fmt.Errorf("failed to publish package for %s/%s: %s",
-				targetDistro.OS, targetDistro.Dist, perr)
+				targetDistro.OS, targetDistro.Dist, err)
 		}
 
-		files, ferr := walkMatch(distPath, patterns)
-		if ferr != nil {
+		files, err := walkMatch(distPath, patterns)
+		if err != nil {
 			return fmt.Errorf("failed to publish package for %s/%s: %s",
-				targetDistro.OS, targetDistro.Dist, ferr)
+				targetDistro.OS, targetDistro.Dist, err)
 		}
 
 		rwsUrlPart := os.Getenv("RWS_URL_PART")