Commit 6527b77
authored
chore: remove
Description
---
Removes the `core_hint_black_box` feature from `subtle`.
Motivation and Context
---
We currently use the `core_hint_black_box` feature from `subtle`, which
uses a particular [optimization
barrier](https://github.com/dalek-cryptography/subtle/blob/6b6a81ad9a6a00c0b42c327eaf4b2f785774377e/src/lib.rs#L245-L250).
However, the standard library
[documentation](https://doc.rust-lang.org/std/hint/fn.black_box.html)
cautions against the use of `std::hint::black_box` for cryptographic
use. This has led `subtle` to [remove
it](dalek-cryptography/subtle#107) in an
upcoming release, at which point the feature will do nothing.
This PR takes the proactive step of removing the feature. There is still
an [optimization
barrier](https://github.com/dalek-cryptography/subtle/blob/6b6a81ad9a6a00c0b42c327eaf4b2f785774377e/src/lib.rs#L227-L243)
in place, which will become the default after the feature is deprecated.
How Has This Been Tested?
---
Existing tests pass.
What process can a PR reviewer use to test or verify this change?
---
Check the claims made in the PR about the feature behavior.subtle feature (#6185)1 parent fa53e0e commit 6527b77
1 file changed
+1
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
27 | | - | |
| 27 | + | |
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
| |||
0 commit comments