Skip to content

Commit 54c97b1

Browse files
Remove subtle feature (#68)
We currently use the `core_hint_black_box` feature from `subtle`, which uses a particular [optimization barrier](https://github.com/dalek-cryptography/subtle/blob/6b6a81ad9a6a00c0b42c327eaf4b2f785774377e/src/lib.rs#L245-L250). However, the standard library [documentation](https://doc.rust-lang.org/std/hint/fn.black_box.html) cautions against the use of `std::hint::black_box` for cryptographic use. This has led `subtle` to [remove it](dalek-cryptography/subtle#107) in an upcoming release, at which point the feature will do nothing. This PR takes the proactive step of removing the feature. There is still an [optimization barrier](https://github.com/dalek-cryptography/subtle/blob/6b6a81ad9a6a00c0b42c327eaf4b2f785774377e/src/lib.rs#L227-L243) in place, which will become the default after the feature is deprecated.
1 parent a86158f commit 54c97b1

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ merlin = { version = "3.0.0", default-features = false }
1717
rand_core = { version = "0.6.4", default-features = false }
1818
serde = { version = "1.0.196", optional = true, default-features = false, features = ["derive"] }
1919
snafu = { version = "0.8.0", default-features = false }
20-
subtle = { version = "2.5.0", default-features = false, features = ["core_hint_black_box"] }
20+
subtle = { version = "2.5.0", default-features = false }
2121
zeroize = { version = "1.7.0", default-features = false }
2222

2323
[dev-dependencies]

0 commit comments

Comments
 (0)