Fix logger init (prevented logging to stderr for tests).

tarickb · tarickb · commit 49d673545b15 · 2023-07-17T18:47:30.000-07:00
diff --git a/src/client.cc b/src/client.cc
@@ -141,10 +141,11 @@ Log::Options GetLogOptions() {
 }
 
 Log::Target GetLogTarget() {
-  if (Config::Get()->always_log_to_syslog() ||
-      Config::Get()->log_to_syslog_on_failure())
+  if (Config::Get()->always_log_to_syslog())
     return Log::TARGET_SYSLOG;
-  return Log::TARGET_NONE;
+  if (!Config::Get()->log_to_syslog_on_failure())
+    return Log::TARGET_NONE;
+  return Log::TARGET_DEFAULT;
 }
 
 }  // namespace

Original file line number	Diff line number	Diff line change
`@@ -141,10 +141,11 @@ Log::Options GetLogOptions() {`
`141`	`141`	`}`
`142`	`142`
`143`	`143`	`Log::Target GetLogTarget() {`
`144`		`- if (Config::Get()->always_log_to_syslog() \|\|`
`145`		`- Config::Get()->log_to_syslog_on_failure())`
	`144`	`+ if (Config::Get()->always_log_to_syslog())`
`146`	`145`	`return Log::TARGET_SYSLOG;`
`147`		`- return Log::TARGET_NONE;`
	`146`	`+ if (!Config::Get()->log_to_syslog_on_failure())`
	`147`	`+ return Log::TARGET_NONE;`
	`148`	`+ return Log::TARGET_DEFAULT;`
`148`	`149`	`}`
`149`	`150`
`150`	`151`	`} // namespace`