Translate some Lwt_unix calls to blocking Unix calls

Using the Eio API in this case might not make sense.

Author: Julow

bin/lwt_to_direct_style/ast_rewrite.ml

@@ -314,6 +314,15 @@ let rewrite_apply ~backend ~state full_ident args =
       (( "printf" | "eprintf" | "stdout" | "stderr" | "fprintf" | "kfprintf"
        | "ifprintf" | "ikfprintf" ) as ident) ) ->
       transparent [ "Format"; ident ]
+  | ( "Lwt_unix",
+      (( "socket" | "socketpair" | "listen" | "shutdown" | "getsockname"
+       | "getpeername" | "waitpid" | "wait4" | "wait" ) as ident) ) ->
+      transparent [ "Unix"; ident ]
+  | "Lwt_unix", (("connect" | "accept" | "bind") as ident) ->
+      Printf.ksprintf (add_comment state)
+        "This call to [Unix.%s] was [Lwt_unix.%s] before. It's now blocking."
+        ident ident;
+      transparent [ "Unix"; ident ]
   | "Lwt_list", ident -> (
       match string_drop_suffix ~suffix:"_s" ident with
       | Some ident -> transparent [ "List"; ident ]

test/lwt_to_direct_style/to_direct_style.t/run.t

@@ -230,7 +230,7 @@ Make a writable directory tree:
     Lwt_mutex.lock (line 136 column 9)
     Lwt_mutex.unlock (line 137 column 9)
     Lwt_mutex.with_lock (line 138 column 9)
-  lib/test_lwt_unix.ml: (47 occurrences)
+  lib/test_lwt_unix.ml: (53 occurrences)
     Lwt_io (line 7 column 8)
     Lwt.return (line 12 column 3)
     Lwt.return (line 46 column 11)
@@ -277,6 +277,12 @@ Make a writable directory tree:
     Lwt_unix.ADDR_UNIX (line 17 column 6)
     Lwt_unix.ADDR_INET (line 17 column 29)
     Lwt_unix.ADDR_INET (line 18 column 3)
+    Lwt_unix.socket (line 50 column 3)
+    Lwt_unix.socketpair (line 51 column 16)
+    Lwt_unix.accept (line 53 column 12)
+    Lwt_unix.connect (line 52 column 14)
+    Lwt_unix.bind (line 54 column 14)
+    Lwt_unix.listen (line 55 column 14)
     Lwt_unix.getaddrinfo (line 20 column 9)
   lib/test.mli: (17 occurrences)
     Lwt (line 12 column 26)
@@ -835,3 +841,23 @@ Make a writable directory tree:
             (* TODO: lwt-to-direct-style: [env] must be propagated from the main loop *)
             (* TODO: lwt-to-direct-style: [sw] (of type Switch.t) must be propagated here. *)
             f 12))
+  
+  let _f a b c = Unix.socket a b c
+  let _f a b c = Unix.socketpair a b c
+  
+  let _f a b =
+    Unix.connect
+      (* TODO: lwt-to-direct-style: This call to [Unix.connect] was [Lwt_unix.connect] before. It's now blocking. *)
+      a b
+  
+  let _f a =
+    Unix.accept
+      (* TODO: lwt-to-direct-style: This call to [Unix.accept] was [Lwt_unix.accept] before. It's now blocking. *)
+      a
+  
+  let _f a b =
+    Unix.bind
+      (* TODO: lwt-to-direct-style: This call to [Unix.bind] was [Lwt_unix.bind] before. It's now blocking. *)
+      a b
+  
+  let _f a b = Unix.listen a b

test/lwt_to_direct_style/to_direct_style.t/src/lib/test_lwt_unix.ml

@@ -45,3 +45,11 @@ let _f = Lwt_preemptive.detach (fun () -> Lwt.return_unit) ()
 let _f =
   let f = Lwt.return in
   Lwt_preemptive.detach f 12
+
+let _f a b c =
+  Lwt_unix.socket a b c
+let _f a b c = Lwt_unix.socketpair a b c
+let _f a b = Lwt_unix.connect a b
+let _f a = Lwt_unix.accept a
+let _f a b = Lwt_unix.bind a b
+let _f a b = Lwt_unix.listen a b