fix(ci): move to tashi-actions-runner (#56)

* fix(ci): move to `tashi-actions-runner`

TODO: docker publish step

* fix(ci): use Github runner for `tmq-docker-publish`

* fix(ci): use CirrusLabs runner for `tmq-build-macos`

* fix: clippy warnings for 1.84

* fix(ci): run `tmq-tests-e2e` on CirrusLabs Linux runner

Author: abonander

.github/workflows/ci.yml

@@ -24,7 +24,7 @@ on:
 jobs:
   tmq-format:
     name: Format
-    runs-on: tashi-arc
+    runs-on: tashi-actions-runner
     timeout-minutes: 10
     steps:
       - name: Check out
@@ -42,7 +42,7 @@ jobs:
 
   tmq-check:
     name: Check
-    runs-on: tashi-arc
+    runs-on: tashi-actions-runner
     timeout-minutes: 10
     steps:
       - name: Check out
@@ -73,7 +73,7 @@ jobs:
 
   tmq-tests-unit:
     name: Unit Tests
-    runs-on: tashi-arc
+    runs-on: tashi-actions-runner
     timeout-minutes: 10
     steps:
       - name: Check out
@@ -102,7 +102,7 @@ jobs:
   tmq-tests-e2e:
     name: End-to-End Tests
     timeout-minutes: 10
-    runs-on: tashi-arc-dind
+    runs-on: ghcr.io/cirruslabs/ubuntu-runner-amd64:22.04-md
     env:
       NODE_VERSION: v20.11.0
     defaults:
@@ -177,7 +177,7 @@ jobs:
     name: Release Build - macOS
     if: ${{ inputs.enable-macOS || inputs.release-version != '' }}
     needs: tmq-check
-    runs-on: macOS
+    runs-on: ghcr.io/cirruslabs/macos-runner:sonoma
     timeout-minutes: 30
     env:
       GIT_SSH_COMMAND: ssh -i .ssh/id_ed25519
@@ -201,9 +201,9 @@ jobs:
           key: macOS-build
 
       - name: Install/Update Rust
-        run: |
-          rustup update stable
-          rustup target add x86_64-apple-darwin
+        uses: actions-rust-lang/setup-rust-toolchain@v1
+        with:
+          target: x86_64-apple-darwin
 
       - name: Build
         run: |
@@ -283,7 +283,7 @@ jobs:
     name: Release Build - Linux
     # This one doesn't cost us anything to run
     needs: tmq-check
-    runs-on: tashi-arc
+    runs-on: tashi-actions-runner
     timeout-minutes: 15
     steps:
       - name: Check out
@@ -320,7 +320,7 @@ jobs:
 
   tmq-draft-release:
     if: ${{ inputs.release-version != '' }}
-    runs-on: tashi-arc
+    runs-on: tashi-actions-runner
     needs:
       - tmq-build-macos
       - tmq-build-windows
@@ -425,12 +425,13 @@ jobs:
 
   tmq-docker-publish:
     if: ${{ inputs.release-version != '' }}
-    runs-on: tashi-arc-dind
+    # Just use CI minutes for this job since it's only run manually.
+    runs-on: ubuntu-latest
     # Just to make sure the rest of the release process went okay.
     needs: tmq-draft-release
     steps:
       - name: Log in to registry
-        run: echo "${{ secrets.GITHUB_TOKEN }}" | docker login ghcr.io -u $ --password-stdin
+        run: echo "${{ secrets.GITHUB_TOKEN }}" | docker login ghcr.io -u ${{ github.actor }} --password-stdin
 
       - name: Fetch Linux Artifact
         uses: actions/download-artifact@v4

src/mqtt/trie/mod.rs

@@ -51,7 +51,7 @@ where
 
         // fixme: This iterator is very inefficient (O(n) scans per tree depth) but it probably doesn't matter because this is a Debug impl.
         // it's O(1) memory usage though.
-        impl<'a, T> Iterator for Iter<'a, T> {
+        impl<T> Iterator for Iter<'_, T> {
             type Item = NodeId;
 
             fn next(&mut self) -> Option<Self::Item> {
@@ -179,7 +179,7 @@ impl<T> FilterTrie<T> {
     pub fn contains_entry(&self, entry_id: EntryId) -> bool {
         self.nodes
             .get(entry_id.node_id)
-            .map_or(false, |it| it[entry_id.leaf_kind].is_some())
+            .is_some_and(|it| it[entry_id.leaf_kind].is_some())
     }
 
     fn lookup(&self, filter: &Filter) -> Option<EntryId> {