fix: remove extra code

Author: abhishekmadan30

src/taskgraph/config.py

@@ -25,6 +25,7 @@
 
 class WorkerAlias(Schema):
     """Worker alias configuration."""
+
     provisioner: optionally_keyed_by("level", str)  # type: ignore
     implementation: str
     os: str
@@ -90,11 +91,6 @@ class GraphConfigSchema(Schema, forbid_unknown_fields=False):
     task_expires_after: Optional[str] = None  # Maps from "task-expires-after"
 
 
-
-# Msgspec schema is now the main schema
-graph_config_schema = GraphConfigSchema
-
-
 @dataclass(frozen=True, eq=False)
 class GraphConfig:
     _config: Dict

src/taskgraph/decision.py

@@ -45,9 +45,6 @@ class TryTaskConfigSchemaV2(Schema):
     parameters: Optional[Dict[str, Any]] = None
 
 
-try_task_config_schema_v2 = TryTaskConfigSchemaV2
-
-
 def full_task_graph_to_runnable_tasks(full_task_json):
     runnable_tasks = {}
     for label, node in full_task_json.items():
@@ -355,7 +352,7 @@ def set_try_config(parameters, task_config_file):
         task_config_version = task_config.pop("version")
         if task_config_version == 2:
             validate_schema(
-                try_task_config_schema_v2,
+                TryTaskConfigSchemaV2,
                 task_config,
                 "Invalid v2 `try_task_config.json`.",
             )

src/taskgraph/parameters.py

@@ -79,10 +79,6 @@ class BaseSchema(Schema):
     code_review: Optional[CodeReviewConfig] = None
 
 
-# Keep backward compatibility
-base_schema = BaseSchema
-
-
 def get_contents(path):
     with open(path) as fh:
         contents = fh.readline().rstrip()
@@ -168,7 +164,7 @@ def extend_parameters_schema(schema, defaults_fn=None):
             dict mapping parameter name to default value in the
             event strict=False (optional).
     """
-    global base_schema
+    global BaseSchema
     global defaults_functions
     global _schema_extensions
 
@@ -249,7 +245,7 @@ def check(self):
                 # Strict mode: validate against schema and check for extra fields
                 # Get all valid field names from the base schema
                 schema_fields = {
-                    f.encode_name for f in msgspec.structs.fields(base_schema)
+                    f.encode_name for f in msgspec.structs.fields(BaseSchema)
                 }
 
                 # Check for extra fields
@@ -260,17 +256,17 @@ def check(self):
                     )
 
                 # Validate all parameters against the schema
-                msgspec.convert(kebab_params, base_schema)
+                msgspec.convert(kebab_params, BaseSchema)
             else:
                 # Non-strict mode: only validate fields that exist in the schema
                 # Filter to only include fields defined in the schema
                 schema_fields = {
-                    f.encode_name for f in msgspec.structs.fields(base_schema)
+                    f.encode_name for f in msgspec.structs.fields(BaseSchema)
                 }
                 filtered_params = {
                     k: v for k, v in kebab_params.items() if k in schema_fields
                 }
-                msgspec.convert(filtered_params, base_schema)
+                msgspec.convert(filtered_params, BaseSchema)
         except (msgspec.ValidationError, msgspec.DecodeError) as e:
             raise ParameterMismatch(f"Invalid parameters: {e}")
 

src/taskgraph/transforms/docker_image.py

@@ -54,10 +54,6 @@ class DockerImageSchema(Schema):
     cache: Optional[bool] = None
 
 
-# Backward compatibility
-docker_image_schema = DockerImageSchema
-
-
 transforms.add_validate(DockerImageSchema)
 
 

src/taskgraph/transforms/fetch.py

@@ -64,9 +64,6 @@ def __post_init__(self):
             raise msgspec.ValidationError("fetch must be a dict with a 'type' field")
 
 
-# Backward compatibility
-FETCH_SCHEMA = FetchSchema
-
 # define a collection of payload builders, depending on the worker implementation
 fetch_builders = {}
 

src/taskgraph/transforms/from_deps.py

@@ -95,9 +95,6 @@ class FromDepsSchema(Schema, forbid_unknown_fields=False):
     from_deps: FromDepsConfig
 
 
-# Backward compatibility
-FROM_DEPS_SCHEMA = FromDepsSchema
-
 transforms = TransformSequence()
 transforms.add_validate(FromDepsSchema)
 

src/taskgraph/transforms/matrix.py

@@ -50,10 +50,8 @@ class MatrixSchema(Schema, forbid_unknown_fields=False):
     matrix: Optional[MatrixConfig] = None
 
 
-MATRIX_SCHEMA = MatrixSchema
-
 transforms = TransformSequence()
-transforms.add_validate(MATRIX_SCHEMA)
+transforms.add_validate(MatrixSchema)
 
 
 def _resolve_matrix(tasks, key, values, exclude):

src/taskgraph/transforms/notify.py

@@ -173,9 +173,6 @@ def __post_init__(self):
             self.notify.recipients = validated_recipients
 
 
-# Backward compatibility
-NOTIFY_SCHEMA = NotifySchema
-
 transforms = TransformSequence()
 transforms.add_validate(NotifySchema)
 

src/taskgraph/transforms/run/__init__.py

@@ -105,15 +105,8 @@ class RunDescriptionSchema(Schema):
     worker: Dict[str, Any] = msgspec.field(default_factory=dict)
 
 
-# Use the msgspec class directly for fetches
-fetches_schema = FetchesSchema
-
-#: Schema for a run transforms - now using msgspec
-run_description_schema = RunDescriptionSchema
-
-
 transforms = TransformSequence()
-transforms.add_validate(run_description_schema)
+transforms.add_validate(RunDescriptionSchema)
 
 
 @transforms.add

src/taskgraph/transforms/run/index_search.py

@@ -25,10 +25,7 @@ class RunTaskSchema(Schema):
     index_search: List[str]
 
 
-run_task_schema = RunTaskSchema
-
-
-@run_task_using("always-optimized", "index-search", schema=run_task_schema)
+@run_task_using("always-optimized", "index-search", schema=RunTaskSchema)
 def fill_template(config, task, taskdesc):
     run = task["run"]
     taskdesc["optimization"] = {