fix(cli): support --exclude-key when attribute may or may not exist

Author: ahal

src/taskgraph/main.py

@@ -96,7 +96,7 @@ def get_filtered_taskgraph(taskgraph, tasksregex, exclude_keys):
             for key in exclude_keys:
                 obj = task
                 attrs = key.split(".")
-                while attrs[0] in obj:
+                while obj and attrs[0] in obj:
                     if len(attrs) == 1:
                         del obj[attrs[0]]
                         break

test/test_main.py

@@ -144,7 +144,7 @@ def test_output_file(run_taskgraph, tmpdir):
                     "description": "",
                     "kind": "task",
                     "label": "b",
-                    "optimization": None,
+                    "optimization": {"skip-unless-changed": True},
                     "soft_dependencies": [],
                     "if_dependencies": [],
                     "task": {
@@ -164,7 +164,7 @@ def test_output_file(run_taskgraph, tmpdir):
                     "description": "",
                     "kind": "task",
                     "label": "b",
-                    "optimization": None,
+                    "optimization": {"skip-unless-changed": True},
                     "soft_dependencies": [],
                     "if_dependencies": [],
                     "task": {
@@ -178,6 +178,7 @@ def test_output_file(run_taskgraph, tmpdir):
             None,
             [
                 "attributes.thing",
+                "optimization.skip-unless-changed",
                 "task.foo.baz",
             ],
             {
@@ -200,7 +201,7 @@ def test_output_file(run_taskgraph, tmpdir):
                     "description": "",
                     "kind": "task",
                     "label": "b",
-                    "optimization": None,
+                    "optimization": {},
                     "soft_dependencies": [],
                     "if_dependencies": [],
                     "task": {
@@ -216,7 +217,11 @@ def test_get_filtered_taskgraph(regex, exclude, expected):
     tasks = {
         "a": Task(kind="task", label="a", attributes={}, task={"foo": {"bar": 1}}),
         "b": Task(
-            kind="task", label="b", attributes={"thing": True}, task={"foo": {"baz": 1}}
+            kind="task",
+            label="b",
+            attributes={"thing": True},
+            optimization={"skip-unless-changed": True},
+            task={"foo": {"baz": 1}},
         ),
     }