Check for slash in route

Author: abhishekmadan30

src/taskgraph/util/verify.py

@@ -206,9 +206,17 @@ def verify_routes_notification_filters(
     )
     task_dict = task.task
     routes = task_dict.get("routes", [])
+    print(f"DEBUG: Task {task.label} routes: {routes}")  
 
     for route in routes:
+        print(f"DEBUG: Checking route: {route}")  
         if route.startswith(route_prefix):
+            # Check for invalid characters in the route
+            if "/" in route:
+                print(f"DEBUG: Found slash in route: {route}")  
+                raise Exception(
+                    f"{task.label} has invalid route with forward slash: {route}"
+                )
             # Get the filter of the route
             route_filter = route.split(".")[-1]
             if route_filter not in valid_filters:

test/test_util_verify.py

@@ -199,6 +199,17 @@ def make_task_treeherder(label, symbol, platform="linux/opt"):
             DeprecationWarning,
             id="routes_notfication_filter: deprecated",
         ),
+        pytest.param(
+            "verify_routes_notification_filters",
+            make_graph(
+                make_task(
+                    "invalid_slash",
+                    task_def={"routes": ["notify.email.default@email/address.on-completed"]},
+                ),
+            ),
+            Exception,
+            id="routes_notification_filter: invalid slash in route",
+        ),
     ),
 )
 @pytest.mark.filterwarnings("error")