Update verify_routes_notification_filters to align with Taskcluster > 37.5.0

PR #3662 introduced `on-defined`, `on-pending` and `on-running`,
and deprecated `on-any` in favor of `on-transition` or `on-resolved`.

Author: jfx2006

src/taskgraph/util/verify.py

@@ -5,6 +5,7 @@
 
 import logging
 import sys
+import warnings
 from abc import ABC, abstractmethod
 from dataclasses import dataclass, field
 from typing import Callable, Dict, List, Union
@@ -192,7 +193,17 @@ def verify_routes_notification_filters(
     if task is None:
         return
     route_prefix = "notify."
-    valid_filters = ("on-any", "on-completed", "on-failed", "on-exception")
+    valid_filters = (
+        "on-any",
+        "on-completed",
+        "on-defined",
+        "on-failed",
+        "on-exception",
+        "on-pending",
+        "on-resolved",
+        "on-running",
+        "on-transition",
+    )
     task_dict = task.task
     routes = task_dict.get("routes", [])
 
@@ -204,6 +215,13 @@ def verify_routes_notification_filters(
                 raise Exception(
                     f"{task.label} has invalid notification filter ({route_filter})"
                 )
+            if route_filter == "on-any":
+                warnings.warn(
+                    DeprecationWarning(
+                        f"notification filter '{route_filter}' is deprecated. Use "
+                        "'on-transition' or 'on-resolved'."
+                    )
+                )
 
 
 @verifications.add("full_task_graph")

test/test_util_verify.py

@@ -163,8 +163,54 @@ def make_task_treeherder(label, symbol, platform="linux/opt"):
             Exception,
             id="task_graph_symbol: too many collections",
         ),
+        pytest.param(
+            "verify_routes_notification_filters",
+            make_graph(
+                make_task(
+                    "good1",
+                    task_def={
+                        "routes": [
+                            "[email protected]"
+                        ]
+                    },
+                ),
+            ),
+            None,
+            id="routes_notfication_filter: valid"
+        ),
+        pytest.param(
+            "verify_routes_notification_filters",
+            make_graph(
+                make_task(
+                    "bad1",
+                    task_def={
+                        "routes": [
+                            "[email protected]"
+                        ]
+                    },
+                ),
+            ),
+            Exception,
+            id="routes_notfication_filter: invalid"
+        ),
+        pytest.param(
+            "verify_routes_notification_filters",
+            make_graph(
+                make_task(
+                    "deprecated",
+                    task_def={
+                        "routes": [
+                            "[email protected]"
+                        ]
+                    },
+                ),
+            ),
+            DeprecationWarning,
+            id="routes_notfication_filter: deprecated"
+        ),
     ),
 )
+@pytest.mark.filterwarnings("error")
 def test_verification(run_verification, name, graph, exception):
     func = partial(run_verification, name, graph=graph)
     if exception: