Skip to content

Commit 9ed586e

Browse files
committed
refactor!: remove 'head_ref' from cached_task PR route
This means that pull requests will share cached_tasks between one another. On the surface this seems wrong, but it is useful when you rebase on PR on top of another one that has already ran. Besides, the digest hash should already prevent PRs from re-using cached_tasks that they shouldn't be. BREAKING CHANGE: changed cached_task pull request index route format Fixes: #413
1 parent 3570746 commit 9ed586e

File tree

2 files changed

+3
-7
lines changed

2 files changed

+3
-7
lines changed

src/taskgraph/util/cached_tasks.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,7 @@
77
import time
88

99
TARGET_CACHE_INDEX = "{cache_prefix}.cache.level-{level}.{type}.{name}.hash.{digest}"
10-
TARGET_PR_CACHE_INDEX = (
11-
"{cache_prefix}.cache.head.{head_ref}.{type}.{name}.hash.{digest}"
12-
)
10+
TARGET_PR_CACHE_INDEX = "{cache_prefix}.cache.pr.{type}.{name}.hash.{digest}"
1311
EXTRA_CACHE_INDEXES = [
1412
"{cache_prefix}.cache.level-{level}.{type}.{name}.latest",
1513
"{cache_prefix}.cache.level-{level}.{type}.{name}.pushdate.{build_date_long}",

test/test_util_cached_tasks.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -84,12 +84,10 @@ def assert_pull_request(task):
8484
"test-domain.cache.level-3.cache-type.cache-name.hash.abc",
8585
"test-domain.cache.level-2.cache-type.cache-name.hash.abc",
8686
"test-domain.cache.level-1.cache-type.cache-name.hash.abc",
87-
"test-domain.cache.head.default.cache-type.cache-name.hash.abc",
87+
"test-domain.cache.pr.cache-type.cache-name.hash.abc",
8888
]
8989
},
90-
"routes": [
91-
"index.test-domain.cache.head.default.cache-type.cache-name.hash.abc"
92-
],
90+
"routes": ["index.test-domain.cache.pr.cache-type.cache-name.hash.abc"],
9391
}
9492

9593

0 commit comments

Comments
 (0)